simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Mon Aug 19 20:43:30 BST 2019


TL;DR:
  40a4c6e0 Unix Plink: stop zeroing out the terminal size in pty-req.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-08-19 20:43:30

commit 40a4c6e06c6b785ee15fd5283eb0d628ddd43408
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=40a4c6e06c6b785ee15fd5283eb0d628ddd43408;hp=50853ddcc3f78cf28b84704abcd686ab865d4089
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Aug 19 20:38:15 2019 +0100

    Unix Plink: stop zeroing out the terminal size in pty-req.
    
    I noticed today that when you use Unix Plink interactively, to run a
    tty session on a remote host starting from a local tty, it doesn't
    copy the local terminal size into the "pty-req" channel request.
    
    It looks as if this is a bug introduced in 2ca0070f8, when I broke up
    ssh.c. Before that, the monolithic Ssh init procedure set
    ssh->term_width and ssh->term_height from the Conf you passed in.
    Afterwards, variables of the same name existed in both ssh.c *and*
    ssh2connection.c (the former so that it can buffer window-size changes
    before a connection layer yet exists to pass them on to), but somehow,
    *neither* source file remembered to initialise them from the Conf.
    
    Fixed by reinstating the initialisation in ssh.c. (For the same reason
    as above: you want the values in Conf to be overwritten if the window
    size changes between ssh_init and ssh2_connection_new.)

 ssh.c | 3 +++
 1 file changed, 3 insertions(+)



More information about the tartarus-commits mailing list