simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  bcf6f52b sshmd5.c: remove excessive return statement
  38e0a3d2 Rename SSH2_KEX_MAX_HASH_LEN to be more general.
  53f0ce3d Forbid variable length arrays
  8d6d7a36 Use a strbuf in ssh_ecdhkex_m_setup.
  2af10ee8 Mention 'no VLAs' in the C-standards UDP section.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-01-02 22:15:50

commit bcf6f52bf2cd746e73738bb6faaff2caeaab8d78
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=bcf6f52bf2cd746e73738bb6faaff2caeaab8d78;hp=24b9e6716dd8e45a80ae62cc181cc1f73add06cf
Author: Pavel I. Kryukov <kryukov at frtk.ru>
Date:   Wed Jan 2 19:55:54 2019 +0300

    sshmd5.c: remove excessive return statement

 sshmd5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 38e0a3d22ebc02aaf8ebdcd151713d294638c240
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=38e0a3d22ebc02aaf8ebdcd151713d294638c240;hp=bcf6f52bf2cd746e73738bb6faaff2caeaab8d78
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Jan 2 22:00:23 2019 +0000

    Rename SSH2_KEX_MAX_HASH_LEN to be more general.
    
    I'm about to want to use it for purposes other than KEX, so it's now
    just called MAX_HASH_LEN and is supposed to be an upper bound on any
    hash function we implement at all. Of course this makes no difference
    to its value, because the largest hash we have is SHA-512 which
    already fit inside that limit.

 ssh.h           | 4 ++--
 ssh2transport.h | 4 ++--
 sshrsa.c        | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

commit 53f0ce3d0c5c82511164effa7916bc79622db215
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=53f0ce3d0c5c82511164effa7916bc79622db215;hp=38e0a3d22ebc02aaf8ebdcd151713d294638c240
Author: Pavel I. Kryukov <kryukov at frtk.ru>
Date:   Wed Jan 2 22:03:13 2019 +0300

    Forbid variable length arrays
    
    Although C99 introduces variable length array (VLA) feature, it is
    not supported by MS Visual Studio (being C++ compiler first of all).
    In this commit, we add Clang and GCC options to disable VLA, so they
    would be disabled in non-MSVC builds as well.

 configure.ac |  2 +-
 mkfiles.pl   | 10 +++++-----
 sshecc.c     |  8 ++++----
 3 files changed, 10 insertions(+), 10 deletions(-)

commit 8d6d7a3615282248415696e281a17ac28096720e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8d6d7a3615282248415696e281a17ac28096720e;hp=53f0ce3d0c5c82511164effa7916bc79622db215
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Jan 2 22:01:38 2019 +0000

    Use a strbuf in ssh_ecdhkex_m_setup.
    
    This removes the one remaining failure at -Wvla. (Of course, that
    array isn't for a _hash_ function, so it wouldn't have been quite
    appropriate to make it a static array of size MAX_HASH_LEN.)

 sshecc.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

commit 2af10ee8d184a8c1cf7619d4d67d27fdb1a33ca7
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=2af10ee8d184a8c1cf7619d4d67d27fdb1a33ca7;hp=8d6d7a3615282248415696e281a17ac28096720e
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Jan 2 22:04:57 2019 +0000

    Mention 'no VLAs' in the C-standards UDP section.
    
    Now we're enforcing it in the build, it ought to be documented as
    well.

 doc/udp.but | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)