simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Jul 2 21:24:10 BST 2019


TL;DR:
  54cd853a Fix buffer overrun on keypress in non-UTF-8 sessions.
  11f504c4 Tighten assertions in Windows wc_to_mb.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-07-02 21:24:10

commit 54cd853a49659a5ec5995bc538d7d3b051da9dfb
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=54cd853a49659a5ec5995bc538d7d3b051da9dfb;hp=e790adec4addbdbc89338d6f0b2cbaa13bffb4ac
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Jul 2 21:22:01 2019 +0100

    Fix buffer overrun on keypress in non-UTF-8 sessions.
    
    Commit 71e42b04a's refactoring of terminal keyboard input, in the case
    where a Unicode string derived from a keystroke is translated into
    some other charset to put on the wire, had allocated the output buffer
    for that translation one byte too small.

 terminal.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

commit 11f504c440d13da6cc95dcfeaa788fa28cd361bf
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=11f504c440d13da6cc95dcfeaa788fa28cd361bf;hp=54cd853a49659a5ec5995bc538d7d3b051da9dfb
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Jul 2 21:22:01 2019 +0100

    Tighten assertions in Windows wc_to_mb.
    
    This assertion was supposed to be checking for the buffer overrun
    fixed by the previous commit, but because it checks the buffer index
    just _after_ writing into the buffer, it would have permitted a
    one-byte overrun before failing the assertion.

 windows/winucs.c | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)



More information about the tartarus-commits mailing list