simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Wed Jul 10 20:43:13 BST 2019


TL;DR:
  04b6db55 Honour the packet size limit in bare-connection protocol.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-07-10 20:43:13

commit 04b6db55f20b7057a5503c0a9f348bfba66b44f7
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=04b6db55f20b7057a5503c0a9f348bfba66b44f7;hp=c8918fea0b65a3b525fec39beba4240d29989bff
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Jul 10 20:32:41 2019 +0100

    Honour the packet size limit in bare-connection protocol.
    
    When I set up the simplified version of just the ssh-connection
    protocol we use for connection sharing, I carefully documented at the
    top of sshshare.c that packets in that protocol variant are limited to
    just over 0x4000 bytes. And did I remember to actually honour that, by
    restricting the sizes of outgoing packets when actually speaking the
    bare connection protocol? I did not.
    
    Well, better late than never. Here I introduce a packet size limit
    that can be imposed by the BPP, and arrange for sshconnection.c to
    take the min of that and any given channel's max packet size as sent
    by the remote end. All BPPs except ssh2bpp-bare set it to the no-op
    value of the largest possible uint32_t.

 ssh1bpp.c        | 1 +
 ssh2bpp-bare.c   | 1 +
 ssh2bpp.c        | 1 +
 ssh2connection.c | 4 ++++
 sshbpp.h         | 1 +
 sshverstring.c   | 1 +
 6 files changed, 9 insertions(+)



More information about the tartarus-commits mailing list