simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  9545199e Completely remove sk_flush().

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-07-28 10:44:04

commit 9545199ea5edb6f7b0fedd27855ab9e467b6f6da
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=9545199ea5edb6f7b0fedd27855ab9e467b6f6da;hp=5e2ac205fd5dab8f2bb306ed66d12237ff51c3f7
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Jul 28 10:32:17 2019 +0100

    Completely remove sk_flush().
    
    I've only just noticed that it doesn't do anything at all!
    
    Almost every implementation of the Socket vtable provides a flush()
    method which does nothing, optionally with a comment explaining why
    it's OK to do nothing. The sole exception is the wrapper Proxy_Socket,
    which implements the method during its setup phase by setting a
    pending_flush flag, so that when its sub-socket is later created, it
    can call sk_flush on that. But since the sub-socket's sk_flush will do
    nothing, even that is completely pointless!
    
    Source control history says that sk_flush was introduced by Dave
    Hinton in 2001 (commit 7b0e08270), who was going to use it for some
    purpose involving the SSL Telnet support he was working on at the
    time. That SSL support was never finished, and its vestigial
    declarations in network.h were removed in 2015 (commit 42334b65b). So
    sk_flush is just another vestige of that abandoned work, which I
    should have removed in the latter commit but overlooked.

 errsock.c          |  1 -
 network.h          |  3 ---
 proxy.c            | 18 ------------------
 unix/uxfdsock.c    |  7 -------
 unix/uxnet.c       |  9 ---------
 windows/winhsock.c |  7 -------
 windows/winnet.c   |  9 ---------
 windows/winnps.c   |  3 +--
 8 files changed, 1 insertion(+), 56 deletions(-)