simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Jun 23 13:55:31 BST 2019


TL;DR:
  02dfae7f ecdsa_new_priv_openssh: use correct free function on failure.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-06-23 13:55:31

commit 02dfae7fe45fb0ea68af976401f65a905edea166
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=02dfae7fe45fb0ea68af976401f65a905edea166;hp=9dcf781d01fd4f8551c926911d6c130e3f6e2f42
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Jun 23 13:50:48 2019 +0100

    ecdsa_new_priv_openssh: use correct free function on failure.
    
    Thanks to Ralf Esswein for pointing out the slip, which should have
    been corrected as part of 867e69187.
    
    It didn't cause a test failure, because the ecdsa and eddsa structs
    are currently so similar in layout (they differ only in the pointed-to
    public key point structure, and on this failure path that pointer is
    NULL anyway). As a result it's rather hard to add a regression test
    against it failing again; I think I just have to chalk this one up to
    the lack of OO-aware type checking when doing this kind of manual
    vtable management in C, unfortunately.

 sshecc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the tartarus-commits mailing list