simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  8c366766 ssh.c: add a missing delete_callbacks_for_context.
  deafaa81 ssh2_try_send: don't try sending if a channel is half-open.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-03-03 10:03:16

commit 8c366766ae125fe1e8e10018589a58725b67968f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8c366766ae125fe1e8e10018589a58725b67968f;hp=0ceb73fb1052345c4a0e20f27c70b078b1b837a6
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Mar 3 06:55:12 2019 +0000

    ssh.c: add a missing delete_callbacks_for_context.
    
    If an Ssh structure is destroyed while its IdempotentCallback
    ssh->ic_out_raw is prnding, then the latter will stay on callback.c's
    list pointing at the freed memory.

 ssh.c | 2 ++
 1 file changed, 2 insertions(+)

commit deafaa811edfdc3cd753515c17eb2c3574001e91
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=deafaa811edfdc3cd753515c17eb2c3574001e91;hp=8c366766ae125fe1e8e10018589a58725b67968f
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Mar 3 07:09:26 2019 +0000

    ssh2_try_send: don't try sending if a channel is half-open.
    
    When ssh2_connection_filter_queue is _receiving_ messages about a
    channel from the other end, it carefully checks if the channel
    referred to is half-open. But we weren't exercising the same caution
    before beginning to _send_ channel data, and we should, because in
    that situation important fields like c->remwinsize aren't even
    initialised yet.
    
    This can come up, for example, due to typeahead in the main session
    window before the server has sent OPEN_CONFIRMATION.

 ssh2connection.c | 48 +++++++++++++++++++++++++-----------------------
 1 file changed, 25 insertions(+), 23 deletions(-)