simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  674219b1 Use sgrowarray_nm in GetDlgItemText_alloc
  1d8b48fd pscp -scp: fix spurious newlines at end of filenames.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-03-21 15:28:02

commit 674219b1150f615acccd2d36ffaa2688b90b871a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=674219b1150f615acccd2d36ffaa2688b90b871a;hp=7631875d41d3eec6116ce9f132058a278df513f1
Author: Sven Strickroth <email at cs-ware.de>
Date:   Tue Mar 19 08:39:08 2019 +0100

    Use sgrowarray_nm in GetDlgItemText_alloc
    
    GetDlgItemText_alloc is often used to get passwords from text fields,
    so the memory should be freed and erased properly. Otherwise parts
    of passwords might leak in memory.
    
    Signed-off-by: Sven Strickroth <email at cs-ware.de>

 windows/winutils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 1d8b48fd22dbfd613e25eb20a3c29acb6f2abe88
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=1d8b48fd22dbfd613e25eb20a3c29acb6f2abe88;hp=674219b1150f615acccd2d36ffaa2688b90b871a
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Mar 21 15:23:51 2019 +0000

    pscp -scp: fix spurious newlines at end of filenames.
    
    Commit d07d7d66f introduced this bug: I replaced a manually grown
    string buffer with a strbuf, and failed to replicate the part where
    after I'd finished appending wire data to the string I removed the
    terminating \n. That string was used as the local file name, when
    downloading in SCP mode using a wildcard, so you'd get lots of local
    files whose names ended inconveniently in a newline character.
    
    Fixed by terminating the loop before we push the \n on to the strbuf
    in the first place.

 pscp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)