simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  fe408562 portfwdmgr_config: null out pointers we're destroying.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-03-25 20:53:24

commit fe408562fa34cbde8ecd5739b24da3d8e6991a4f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=fe408562fa34cbde8ecd5739b24da3d8e6991a4f;hp=8c710dddc585022ad6503d0bfb3eb7291b6ef05c
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Mar 25 20:49:04 2019 +0000

    portfwdmgr_config: null out pointers we're destroying.
    
    In particular, a report today pointed out that the call to
    pfl_terminate(pfr->local) directly from portfwdmgr_config() was then
    repeated from inside pfr_free(pfr) which we called four lines later,
    leading to a double-free crash. Now we null out pfr->local the first
    time, so the call in pfr_free is skipped.
    
    While I'm at it, I've nulled out pfr->remote similarly; that doesn't
    cause any crash that I can see, but it's a good habit to get into for
    futureproofing.

 portfwd.c | 2 ++
 1 file changed, 2 insertions(+)