simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  4adbd725 Fix use-after-free in banner handling.
  717571d2 gtkcompat.h: fix GTK1 implementation of ref_sink.
  2e93c386 Fix config-panel switching on GTK 1.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-11-02 08:39:44

commit 4adbd725caecdbf85034a55d9aa3090f8d873683
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=4adbd725caecdbf85034a55d9aa3090f8d873683;hp=d1613e81470450e103394ab47ff221aa7bf1a26c
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 2 08:23:58 2019 +0000

    Fix use-after-free in banner handling.
    
    When we fetch a chunk of data from the banner bufchain, we have to
    read from it _before_ calling bufchain_consume.

 ssh2userauth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 717571d25f80737dc7bb82d3c67942126595769a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=717571d25f80737dc7bb82d3c67942126595769a;hp=4adbd725caecdbf85034a55d9aa3090f8d873683
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 2 08:26:14 2019 +0000

    gtkcompat.h: fix GTK1 implementation of ref_sink.
    
    I was testing some upcoming new GTK code against all GTK versions,
    which for once was interesting enough to make nontrivial use of
    g_object_ref_sink, and I found that I hadn't implemented the GTK1
    fallback version right. GTK1 has no ref_sink call, but it does have
    ref and sink, so the right thing seems to be to just call them in
    succession.

 unix/gtkcompat.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

commit 2e93c3868e012c7a7750dea89874b70c96632fde
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=2e93c3868e012c7a7750dea89874b70c96632fde;hp=717571d25f80737dc7bb82d3c67942126595769a
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 2 08:37:30 2019 +0000

    Fix config-panel switching on GTK 1.
    
    When I reworked the 'selparams' array in commit e790adec4 to contain
    pointers to 'struct selparam' rather than directly containing
    structures, I missed this one case where I should have removed an &.
    As a result the GTK1 signal handler that deals with clicks on the
    config-pane selection treeview was getting a pointer to a pointer and
    treating it as a pointer to an object. Nothing good happened.

 unix/gtkdlg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)