simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  283bd541 Fix handling of string-typed address from SOCKS5 server.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-10-01 19:37:47

commit 283bd541a61555cd3ab18e3c686894dcc6576b1b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=283bd541a61555cd3ab18e3c686894dcc6576b1b;hp=745ed3ad3beaf52fc623827e770b3a068b238dd5
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Oct 1 19:31:37 2019 +0100

    Fix handling of string-typed address from SOCKS5 server.
    
    In the variable-length address slot, the main SOCKS5 reply packet can
    contain a binary IP address (4- or 16-byte for v4/v6 respectively), or
    a string intended to be interpreted as a domain name.
    
    I was trying out the Python SOCKS5 proxy 'pproxy' today, which sends a
    string-typed reply if you send it a string-typed domain name to
    connect to. This caused me to notice that PuTTY mishandles the latter
    case, by failing to account for the prefix length byte of that string
    when computing the total size of the reply packet. So we would
    misinterpret the final byte of its reply packet as the initial byte of
    the actual connection, causing us to fail to recognise the SSH greeting.

 proxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)