simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Oct 20 19:04:15 BST 2019


TL;DR:
  c24313c0 Remove extra braces in drawing_area_setup. (NFC)
  d1613e81 GTK: Refresh backing surface when border is reconfigured.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2019-10-20 19:04:15

commit c24313c0b35394fd2a32fd2943324d68f103f89c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c24313c0b35394fd2a32fd2943324d68f103f89c;hp=444e7c70e752e30791baefb0f4adb70822b11947
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Oct 20 18:47:33 2019 +0100

    Remove extra braces in drawing_area_setup. (NFC)
    
    I'm about to rearrange this function, and the patch that actually does
    work will be easier to read if mass reindentation isn't combined with
    it.
    
    The braces I've just removed were necessary when we hadn't yet
    committed to requiring (most of) C99 from all our build platforms. Now
    they aren't.

 unix/gtkwin.c | 34 ++++++++++++++++------------------
 1 file changed, 16 insertions(+), 18 deletions(-)

commit d1613e81470450e103394ab47ff221aa7bf1a26c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d1613e81470450e103394ab47ff221aa7bf1a26c;hp=c24313c0b35394fd2a32fd2943324d68f103f89c
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Oct 20 18:47:04 2019 +0100

    GTK: Refresh backing surface when border is reconfigured.
    
    If you go to Change Settings in Unix PuTTY or pterm, and change the
    'Gap between text and window edge' setting but not the width and
    height, then change_settings_menuitem() correctly sets the physical
    window to a new size, but drawing_area_setup() was not recreating the
    backing surface / pixmap in the same way, because it hadn't spotted
    that the border size might be relevant.
    
    Now I unconditionally work out what the exact size of the backing
    surface _ought_ to be, before reaching the potential early exit path,
    and never take the early exit if the backing area needs resizing for
    any reason at all.
    
    (I think this probably ought to have been part of commit 528513dde.)

 unix/gtkwin.c | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)



More information about the tartarus-commits mailing list