simon-git: putty (master): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Sat Apr 18 13:36:22 BST 2020
TL;DR:
df2994a0 Make the backend_init error message dynamic. (NFC)
21492da8 Improve serial-port setup error messages.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2020-04-18 13:36:22
commit df2994a05ab4a353b90cbda04ce5b45c6a238692
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=df2994a05ab4a353b90cbda04ce5b45c6a238692;hp=d9c4ce9fd8ed21b64bf35367b45374bd7b1afcf0
Author: Simon Tatham <anakin at pobox.com>
Date: Sat Apr 18 13:28:33 2020 +0100
Make the backend_init error message dynamic. (NFC)
Now, instead of a 'const char *' in the static data segment, error
messages returned from backend setup are dynamically allocated and
freed by the caller.
This will allow me to make the messages much more specific (including
errno values and the like). However, this commit is pure refactoring:
I've _just_ changed the allocation policy, and left all the messages
alone.
putty.h | 10 +++++-----
raw.c | 12 ++++++------
rlogin.c | 12 ++++++------
ssh.c | 22 +++++++++++-----------
supdup.c | 14 +++++++-------
telnet.c | 12 ++++++------
testback.c | 26 ++++++++++++--------------
unix/gtkwin.c | 4 ++--
unix/uxplink.c | 4 ++--
unix/uxpty.c | 8 ++++----
unix/uxser.c | 22 ++++++++++++----------
windows/window.c | 4 ++--
windows/winplink.c | 4 ++--
windows/winser.c | 21 +++++++++++----------
14 files changed, 88 insertions(+), 87 deletions(-)
commit 21492da89e3f9d387c8992d85df6d9807fe12027
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=21492da89e3f9d387c8992d85df6d9807fe12027;hp=df2994a05ab4a353b90cbda04ce5b45c6a238692
Author: Simon Tatham <anakin at pobox.com>
Date: Sat Apr 18 13:30:42 2020 +0100
Improve serial-port setup error messages.
Now you can see exactly what pathname the backend tried to open for
the serial port, and what error code it got back from the OS when it
tried. That should help users distinguish between (for example) a
permissions problem and a typo in the filename.
unix/uxser.c | 5 +++--
windows/winser.c | 68 ++++++++++++++++++++++++++++++--------------------------
2 files changed, 39 insertions(+), 34 deletions(-)
More information about the tartarus-commits
mailing list