simon-git: spigot (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  02159d7 Use make -j to speed up the build.
  ecdd467 Stop running sphinx-build on Python 2.
  04e6bb4 gcc9 warning fix: remove pessimising moves.
  9910e5b gcc9 warning fix: catch spigot_error by reference.

Repository:     https://git.tartarus.org/simon/spigot.git
On the web:     https://git.tartarus.org/?p=simon/spigot.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-08-31 18:56:53

commit 02159d7b9daf39050deab9752b527bb989a3e044
web diff https://git.tartarus.org/?p=simon/spigot.git;a=commitdiff;h=02159d7b9daf39050deab9752b527bb989a3e044;hp=216f4ca989cdb821c3e88d9351e7f58157e8d989
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Aug 31 18:34:34 2020 +0100

    Use make -j to speed up the build.
    
    When I added $(nproc) to bob, I apparently also added it to all the
    make commands in all my build scripts _except_ this one.

 Buildscr | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit ecdd4674ac33867ef0ffec9dc5969e3e8a49bc72
web diff https://git.tartarus.org/?p=simon/spigot.git;a=commitdiff;h=ecdd4674ac33867ef0ffec9dc5969e3e8a49bc72;hp=02159d7b9daf39050deab9752b527bb989a3e044
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Aug 31 18:35:09 2020 +0100

    Stop running sphinx-build on Python 2.
    
    This unbreaks my build, which would otherwise stop working because my
    build machine has just been upgraded to Ubuntu 20.04, on which the
    Python 2 version of sphinx-build no longer exists.
    
    We weren't making much _use_ of the P2 sphinx build - it was just
    running the doctests and the test coverage. So this should make no
    difference to the build products themselves, but we no longer have any
    protection against accidentally writing a code snippet in the docs
    that only works in P3.
    
    (It may well be a good idea to throw away P2 support in this module
    anyway, now that P2 is becoming ever deader.)

 Buildscr | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

commit 04e6bb4069287d7d41b0c2ab5ae3766023eb8b63
web diff https://git.tartarus.org/?p=simon/spigot.git;a=commitdiff;h=04e6bb4069287d7d41b0c2ab5ae3766023eb8b63;hp=ecdd4674ac33867ef0ffec9dc5969e3e8a49bc72
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Aug 31 18:40:01 2020 +0100

    gcc9 warning fix: remove pessimising moves.
    
    This fixes a collection of warnings of the form 'warning: moving a
    local object in a return statement prevents copy elision'.

 erf.cpp       | 4 ++--
 hypergeom.cpp | 2 +-
 lambertw.cpp  | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

commit 9910e5bdc203bae6b7bbe1ed4a93f13755c1caee
web diff https://git.tartarus.org/?p=simon/spigot.git;a=commitdiff;h=9910e5bdc203bae6b7bbe1ed4a93f13755c1caee;hp=04e6bb4069287d7d41b0c2ab5ae3766023eb8b63
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Aug 31 18:41:31 2020 +0100

    gcc9 warning fix: catch spigot_error by reference.
    
    The warning was "warning: catching polymorphic type ‘class
    spigot_error’ by value".
    
    Now they point it out, I can see several reasons why it might be a bad
    idea to copy the base-class part of a derived error class into a bare
    instance of the base class: if there are vtables, most obviously, and
    also if the base variables are in a state that only makes sense in the
    context of the derived class.
    
    In this case, all my error classes only contain a string, so I think
    it was likely benign - but then, this change will surely also avoid a
    pointless copy, so it's a mild performance improvement too.

 hypergeom.cpp              |  2 +-
 main.cpp                   |  6 +++---
 python-module/internal.cpp | 26 +++++++++++++-------------
 3 files changed, 17 insertions(+), 17 deletions(-)