simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  456120cf Rewrite MD5 implementation in my modern style.
  31cd5ee1 Fix buffer overflow in NEON SHA-384 output.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-12-24 17:42:57

commit 456120cfac29cf67e039868762864f0cf4d0e7e8
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=456120cfac29cf67e039868762864f0cf4d0e7e8;hp=a9763ce4ed8e01d4351c0873529b3bf88d2653d0
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Dec 24 17:08:55 2020 +0000

    Rewrite MD5 implementation in my modern style.
    
    MD5 is structurally very similar to all the SHA-1 and SHA-2 hashes
    (with the main difference being that the message schedule consists of
    just repeating the 32-bit words of the message four times in different
    permutations, instead of transforming them via an LFSR-style process).
    So it helps legibility and maintainability if all the implementations
    of these hashes are coded in a similar style - for example, that way,
    the next time I need to make a change to the ssh_hash API, I can do it
    the same way in all these modules without having to think everything
    out again.
    
    After the SHA-512 rewrite earlier today, all the hashes in that family
    had been updated to a consistent new style as a side effect of adding
    optional hardware acceleration, except for MD5, because there's no
    hardware-accelerated version of it. (And not much chance of anyone
    ever needing one, I hope!)
    
    So this is a purely stylistic update which reworks MD5 so that it
    looks just like all the SHA-1 and SHA-2 hash implementations. No
    functional change.

 sshmd5.c | 386 +++++++++++++++++++++++++++++----------------------------------
 1 file changed, 180 insertions(+), 206 deletions(-)

commit 31cd5ee19b14be4b1b342e0588c491fd8dfd69d2
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=31cd5ee19b14be4b1b342e0588c491fd8dfd69d2;hp=456120cfac29cf67e039868762864f0cf4d0e7e8
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Dec 24 17:36:12 2020 +0000

    Fix buffer overflow in NEON SHA-384 output.
    
    An obvious goof - in SHA-384, you don't want to write out the last of
    the four state vectors! Fortunately I spotted it only a couple of
    hours after introducing it.

 sshsh512.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)