simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  b9c42bc9 Simplify the Pageant internal client code.
  8677ee00 Minor memory leaks in Pageant client code.
  55005a08 Unix Pageant: -E option to load key files encrypted.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-02-08 17:37:35

commit b9c42bc9b379df27dea55a93e79741dc08a3af5e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=b9c42bc9b379df27dea55a93e79741dc08a3af5e;hp=bdb7b47a5ec9809c9ea2544a02c36968a714c788
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Feb 8 16:36:55 2020 +0000

    Simplify the Pageant internal client code.
    
    Until now, all the functions that have to work in both the Pageant
    server and a separate client process have been implemented by having
    two code paths for every request, one of which marshals an agent
    request and passes it to agent_query_synchronous, and the other just
    calls one of the internal functions in the Pageant core.
    
    This is already quite ugly, and it'll only get worse when I start
    adding more client requests. So here's a simplification: now, there's
    only one code path, and we _always_ marshal a wire-format agent
    request. When we're the same process as the Pageant server, we pass it
    to the actual message handler and let that decode it again, enforcing
    by assertion that it's not an asynchronous operation that's going to
    delay.
    
    This patch removes a layer of indentation from many functions in the
    Pageant client layer, so it's best viewed with whitespace ignored.

 pageant.c | 264 +++++++++++++++++++++++++++++++++++---------------------------
 1 file changed, 150 insertions(+), 114 deletions(-)

commit 8677ee00fb55ddfa0eb7d554bfb9da0c778a8acf
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8677ee00fb55ddfa0eb7d554bfb9da0c778a8acf;hp=b9c42bc9b379df27dea55a93e79741dc08a3af5e
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Feb 8 16:56:30 2020 +0000

    Minor memory leaks in Pageant client code.

 pageant.c | 2 ++
 1 file changed, 2 insertions(+)

commit 55005a08ea782fda8ae5a76cfb97fbd5d0f821ab
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=55005a08ea782fda8ae5a76cfb97fbd5d0f821ab;hp=8677ee00fb55ddfa0eb7d554bfb9da0c778a8acf
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Feb 8 17:28:46 2020 +0000

    Unix Pageant: -E option to load key files encrypted.
    
    This applies to both server modes ('pageant -E key.ppk [lifetime]')
    and client mode ('pageant -a -E key.ppk').
    
    I'm not completely confident that the CLI syntax is actually right
    yet, but for the moment, it's enough that it _exists_. Now I don't
    have to test the encrypted-key loading via manually mocked-up agent
    requests.

 pageant.c         | 39 ++++++++++++++++++++++++++++++++++++++-
 pageant.h         |  2 +-
 unix/uxpgnt.c     | 34 ++++++++++++++++++++++++++--------
 windows/winpgnt.c |  4 ++--
 4 files changed, 67 insertions(+), 12 deletions(-)