simon-git: putty (master): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Feb 11 19:16:03 GMT 2020


TL;DR:
  125ddd13 Pageant: fix misuse of the blocked_requests queue.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-02-11 19:16:03

commit 125ddd131c04a2426174914cf933113526363c7a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=125ddd131c04a2426174914cf933113526363c7a;hp=014886142cf81a6d427a91882822f8ed9bd01ddf
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Feb 11 19:11:10 2020 +0000

    Pageant: fix misuse of the blocked_requests queue.
    
    A PageantSignOp for a not-yet-decrypted key was being linked on to its
    key's blocked_requests queue twice, mangling the linked list integrity
    and causing segfaults. Now we take care to NULL out the pointers
    within the signop to indicate that it isn't currently on the queue,
    and check whether it's currently linked before linking or unlinking it.

 pageant.c | 37 ++++++++++++++++++++++++++-----------
 1 file changed, 26 insertions(+), 11 deletions(-)



More information about the tartarus-commits mailing list