simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  62733a83 Revert "New vtable API for keygen progress reporting."
  79d3c178 New vtable API for keygen progress reporting.
  750f5222 Factor out Miller-Rabin checking into its own file.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-02-29 17:01:32

commit 62733a838906fe0b103e47fe821c454ed899e73b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=62733a838906fe0b103e47fe821c454ed899e73b;hp=a7bdefb3942fec5fca41bfa46d77d70b1d6e4fd2
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Feb 29 16:32:16 2020 +0000

    Revert "New vtable API for keygen progress reporting."
    
    This reverts commit a7bdefb3942fec5fca41bfa46d77d70b1d6e4fd2.
    
    I had accidentally mashed it together with another commit. I did
    actually want to push both of them, but I'd rather push them
    separately! So I'm backing out the combined blob, and I'll re-push
    them with their proper comments and explanations.

 Recipe             |   2 +-
 cmdgen.c           |  62 +++++++-------
 millerrabin.c      | 214 ------------------------------------------------
 ssh.h              |  20 +++++
 ssh1login-server.c |   6 +-
 ssh2kex-server.c   |  12 +--
 sshdssg.c          |  74 ++++++++++-------
 sshecdsag.c        |   7 +-
 sshkeygen.h        |  93 +--------------------
 sshprime.c         | 233 ++++++++++++++++++++++++++++++++++++-----------------
 sshrsag.c          |  56 ++++++++++---
 testcrypt.c        |  12 +--
 windows/winpgen.c  | 162 +++++++++++++++----------------------
 13 files changed, 392 insertions(+), 561 deletions(-)

commit 79d3c1783b8a9cc7879a2f10b676bfa058731324
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=79d3c1783b8a9cc7879a2f10b676bfa058731324;hp=62733a838906fe0b103e47fe821c454ed899e73b
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Feb 23 15:29:40 2020 +0000

    New vtable API for keygen progress reporting.
    
    The old API was one of those horrible things I used to do when I was
    young and foolish, in which you have just one function, and indicate
    which of lots of things it's doing by passing in flags. It was crying
    out to be replaced with a vtable.
    
    While I'm at it, I've reworked the code on the Windows side that
    decides what to do with the progress bar, so that it's based on
    actually justifiable estimates of probability rather than magic
    integer constants.
    
    Since computers are generally faster now than they were at the start
    of this project, I've also decided there's no longer any point in
    making the fixed final part of RSA key generation bother to report
    progress at all. So the progress bars are now only for the variable
    part, i.e. the actual prime generations.
    
    (This is a reapplication of commit a7bdefb39, without the Miller-Rabin
    refactoring accidentally folded into it. Also this time I've added -lm
    to the link options, which for some reason _didn't_ cause me a link
    failure last time round. No idea why not.)

 cmdgen.c           |  62 ++++++++++----------
 configure.ac       |   2 +
 ssh.h              |  20 -------
 ssh1login-server.c |   6 +-
 ssh2kex-server.c   |  12 ++--
 sshdssg.c          |  74 +++++++++---------------
 sshecdsag.c        |   7 +--
 sshkeygen.h        |  68 +++++++++++++++++++++-
 sshprime.c         |  90 +++++++++++++++++++++++++----
 sshrsag.c          |  56 ++++--------------
 testcrypt.c        |  12 ++--
 windows/winpgen.c  | 162 +++++++++++++++++++++++++++++++----------------------
 12 files changed, 327 insertions(+), 244 deletions(-)

commit 750f5222b29f723b3669082301bcd10cfea68a4b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=750f5222b29f723b3669082301bcd10cfea68a4b;hp=79d3c1783b8a9cc7879a2f10b676bfa058731324
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Feb 29 16:44:56 2020 +0000

    Factor out Miller-Rabin checking into its own file.
    
    This further cleans up the prime-generation code, to the point where
    the main primegen() function has almost nothing in it. Also now I'll
    be able to reuse M-R as a primitive in more sophisticated alternatives
    to primegen().

 Recipe        |   2 +-
 millerrabin.c | 214 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 sshkeygen.h   |  25 +++++++
 sshprime.c    | 192 ++++++----------------------------------------------
 4 files changed, 260 insertions(+), 173 deletions(-)