simon-git: tweak (master): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Thu Jun 4 12:50:27 BST 2020
TL;DR:
f8bc703 Missing conversions to 'bool' in slang.c.
354179f slang.c: update to libslang 2.
df88eac Check return value of fread.
6086a85 Exit the program if we fail to read a keystroke.
ad97e13 Fix buffer overflow in 'unknown key sequence' error report.
d131fe2 Switch to an autotools makefile.
Repository: https://git.tartarus.org/simon/tweak.git
On the web: https://git.tartarus.org/?p=simon/tweak.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2020-06-04 12:50:27
commit f8bc703221806b55236ee9630b2abc334ea2b510
web diff https://git.tartarus.org/?p=simon/tweak.git;a=commitdiff;h=f8bc703221806b55236ee9630b2abc334ea2b510;hp=e9c06a706d2e5ebc40f78be60c430a3cd9b5edd2
Author: Simon Tatham <anakin at pobox.com>
Date: Mon Jun 1 09:00:07 2020 +0100
Missing conversions to 'bool' in slang.c.
That source file isn't used in my normal build, so I managed to
completely forget about it when I did the bool conversion.
slang.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
commit 354179fa72f97130153ad7d619e9875589f7f2e7
web diff https://git.tartarus.org/?p=simon/tweak.git;a=commitdiff;h=354179fa72f97130153ad7d619e9875589f7f2e7;hp=f8bc703221806b55236ee9630b2abc334ea2b510
Author: Simon Tatham <anakin at pobox.com>
Date: Mon Jun 1 09:00:40 2020 +0100
slang.c: update to libslang 2.
Only one change was needed: direct access to SLang_Error is now
forbidden, and the accessor function SLang_set_error is used instead.
slang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit df88eacdd6769c14fe14d58dd15a9aae3ce6532d
web diff https://git.tartarus.org/?p=simon/tweak.git;a=commitdiff;h=df88eacdd6769c14fe14d58dd15a9aae3ce6532d;hp=354179fa72f97130153ad7d619e9875589f7f2e7
Author: Simon Tatham <anakin at pobox.com>
Date: Mon Jun 1 09:07:01 2020 +0100
Check return value of fread.
This fixes the only warning at -Wall.
buffer.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
commit 6086a8529b41aaca28eed9461c511c50c32aa1a0
web diff https://git.tartarus.org/?p=simon/tweak.git;a=commitdiff;h=6086a8529b41aaca28eed9461c511c50c32aa1a0;hp=df88eacdd6769c14fe14d58dd15a9aae3ce6532d
Author: Simon Tatham <anakin at pobox.com>
Date: Mon Jun 1 08:00:50 2020 +0100
Exit the program if we fail to read a keystroke.
This shouldn't come up in normal usage: if run in a terminal in the
normal way, the terminal window closing should deliver SIGHUP to
Tweak, which is normally fatal.
But sometimes SIGHUP is not received. One reason could be that a
parent process had blocked it; another is that if there's a sudo in
between the terminal and Tweak, then apparently SIGHUP fails to
propagate through sudo. So this fallback precaution is sometimes
needed.
curses.c | 4 ++++
slang.c | 7 ++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
commit ad97e1337e1e1df934b7f3674fa6c9f7e8eb603f
web diff https://git.tartarus.org/?p=simon/tweak.git;a=commitdiff;h=ad97e1337e1e1df934b7f3674fa6c9f7e8eb603f;hp=6086a8529b41aaca28eed9461c511c50c32aa1a0
Author: Simon Tatham <anakin at pobox.com>
Date: Tue Jun 2 10:29:40 2020 +0100
Fix buffer overflow in 'unknown key sequence' error report.
That code definitely shows signs of me having been a student when I
wrote it! These days I'd never absent-mindedly append stuff to a
fixed-size buffer like that.
keytab.c | 51 +++++++++++++++++++++++++++++++++++++--------------
1 file changed, 37 insertions(+), 14 deletions(-)
commit d131fe23e3306d4a2fb649695633937e0e12e356
web diff https://git.tartarus.org/?p=simon/tweak.git;a=commitdiff;h=d131fe23e3306d4a2fb649695633937e0e12e356;hp=ad97e1337e1e1df934b7f3674fa6c9f7e8eb603f
Author: Simon Tatham <anakin at pobox.com>
Date: Mon Jun 1 08:01:56 2020 +0100
Switch to an autotools makefile.
The old one was confusingly at variance with the automake conventions.
For example, it had -c as part of CFLAGS, so that if you ran 'make
CFLAGS="-g -O0"', the makefile would try to link each object file
separately, and fail spectacularly.
The old manual make definition for NO_LARGE_FILES is replaced by
autoconf auto-detection in the obvious way. ncurses versus slang is
auto-detected as well by availability, although --with-{ncurses,slang}
can be used to express a preference.
.gitignore | 13 ++++++++++
Buildscr | 24 ++++++++++++++---
Makefile | 84 ------------------------------------------------------------
Makefile.am | 23 +++++++++++++++++
autogen.sh | 2 ++
configure.ac | 49 +++++++++++++++++++++++++++++++++++
tweak.h | 14 +++++-----
7 files changed, 115 insertions(+), 94 deletions(-)
More information about the tartarus-commits
mailing list