simon-git: putty (master): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Sun Mar 1 08:37:34 GMT 2020
TL;DR:
a7f409eb Fix VS 2015 build failure.
8b672835 DSA key gen: start from 2 when looking for g.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2020-03-01 08:37:34
commit a7f409eb61751cc4126ec0fbe13403ce0643d692
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=a7f409eb61751cc4126ec0fbe13403ce0643d692;hp=750f5222b29f723b3669082301bcd10cfea68a4b
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Mar 1 08:26:04 2020 +0000
Fix VS 2015 build failure.
Thanks to Pavel Kryukov's CI for pointing this out: VS 2015 doesn't
support C99 hex floating-point literals.
(VS 2017 does, and in general we're treating this as a C99-permitted
code base these days. So I was tempted to just increase the minimum
required compiler version and leave this code as it is. But since the
use of that particular floating literal was so totally frivolous and
unnecessary, I think I'll leave that for another day when it's more
important!)
sshdssg.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
commit 8b672835c1b764c899352d3db96a2667fa855a2a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8b672835c1b764c899352d3db96a2667fa855a2a;hp=a7f409eb61751cc4126ec0fbe13403ce0643d692
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Mar 1 08:27:54 2020 +0000
DSA key gen: start from 2 when looking for g.
Having just written a comment about how it was almost inconceivably
improbable that you _wouldn't_ be successful in finding a suitable g
on the very first number you tried, I couldn't help noticing that in
fact my very next DSA key generation test had to try twice. Had I made
a mistake in my probability theory?
No, it turns out: I find g by raising consecutive numbers to the power
(p-1)/q and looking to see if they're not 1, but I start with 1
itself, which along with -1 is the only number that _can't_ work!
Save a bit of pointless effort and iterate up from 2 instead.
sshdssg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
More information about the tartarus-commits
mailing list