simon-git: putty (master): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  c373fe97 fuzzterm.c: fix prototypes of stub dlg functions.
  c5aa7fc3 sshserver.c: fix prototype of mainchan_new.
  99f5fa34 uxucs.c: fix type of wcrtomb return value.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-05-16 16:33:11

commit c373fe979fcc395c3efd0b12bd11b9061e45d7a4
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c373fe979fcc395c3efd0b12bd11b9061e45d7a4;hp=4948b79114aca6150800c7539395fdc7c391efdc
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat May 16 16:08:21 2020 +0100

    fuzzterm.c: fix prototypes of stub dlg functions.
    
    I'd forgotten to #include "dialog.h" in that file, which meant nothing
    was checking the prototypes of the stub implementations of the dlg_*
    function family against the real versions. They almost all needed a
    'void *dlg' parameter updating to 'dlgparam *dp', which is a change
    dating from commit 3aae1f9d76 nearly two years ago. And a handful of
    them also still had 'int' that should be now have become 'bool'.

 fuzzterm.c | 65 +++++++++++++++++++++++++++++++++-----------------------------
 1 file changed, 35 insertions(+), 30 deletions(-)

commit c5aa7fc31c4b57d07967ed8a88b77ff79cb5d44f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c5aa7fc31c4b57d07967ed8a88b77ff79cb5d44f;hp=c373fe979fcc395c3efd0b12bd11b9061e45d7a4
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat May 16 16:11:55 2020 +0100

    sshserver.c: fix prototype of mainchan_new.
    
    Again, there was a missing #include in that file which meant that the
    definition of the function was never being checked against the
    declaration visible to other source files.

 sshserver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

commit 99f5fa34ab918894939c8aca00e44730223c0e54
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=99f5fa34ab918894939c8aca00e44730223c0e54;hp=c5aa7fc31c4b57d07967ed8a88b77ff79cb5d44f
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat May 16 16:14:13 2020 +0100

    uxucs.c: fix type of wcrtomb return value.
    
    wcrtomb returns a size_t, so it's silly to immediately assign it into
    an int variable. Apparently running gcc with LTO enabled points this
    out as an error.
    
    This was benign as far as I can see: the obvious risk of integer
    overflow could only happen if the OS wanted to convert a single wide
    character into more than 2^31 bytes, and the test of the return value
    against (size_t)-1 for an error check seems to work anyway in
    practice, although I suspect that's only because of implementation-
    defined behaviour in gcc at the point where the size_t is narrowed to
    a signed int.

 unix/uxucs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)