simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  4ad554d2 Fix printf warnings at -DDEBUG.
  ffce7d8e Cope with a GdkEventKey having a NULL string field.
  8dfc39bf gtk: make Ctrl processing notice if use_ucsoutput is true.
  12d483a1 Don't advertise ext-info-[cs] during rekeys.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2020-11-24 20:57:46

commit 4ad554d23b7be176d612f43778488016856a2578
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=4ad554d23b7be176d612f43778488016856a2578;hp=ca73159c14782c4790d393ab3872c3581dc986bf
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Nov 24 20:38:36 2020 +0000

    Fix printf warnings at -DDEBUG.
    
    I must have not recompiled with debug printouts enabled since updating
    the internal printf functions to have the gcc printf attribute, or
    these warnings would surely have come up before.

 unix/gtkwin.c | 2 +-
 utils.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

commit ffce7d8e70f357150256e5074732cf6594b8fc74
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=ffce7d8e70f357150256e5074732cf6594b8fc74;hp=4ad554d23b7be176d612f43778488016856a2578
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Nov 24 20:37:47 2020 +0000

    Cope with a GdkEventKey having a NULL string field.
    
    When you run using the GDK Broadway backend, this turns out to happen,
    and it's new in my experience - I was cheerfully iterating over
    event->string and calling strlen on it without ever checking it for
    NULL.

 unix/gtkwin.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

commit 8dfc39bfb48bcbf71c57b1f870d9ade2ad4b730a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8dfc39bfb48bcbf71c57b1f870d9ade2ad4b730a;hp=ffce7d8e70f357150256e5074732cf6594b8fc74
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Nov 24 20:41:25 2020 +0000

    gtk: make Ctrl processing notice if use_ucsoutput is true.
    
    Again in the GDK Broadway backend, where we never get a non-Unicode
    translation of any keystroke: when we come to the code that handles
    Ctrl+letter (and other symbols), we were basing the Ctrl transform on
    output[1], that is, the non-Unicode translation we had so far. But we
    didn't have one.
    
    Now we check the use_ucsoutput flag to decide which of output and
    ucsoutput to start from, and as a result, Ctrl+keys works again on
    Broadway.

 unix/gtkwin.c | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

commit 12d483a14899979a0e800657d9ead33175fae498
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=12d483a14899979a0e800657d9ead33175fae498;hp=8dfc39bfb48bcbf71c57b1f870d9ade2ad4b730a
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Nov 24 20:54:07 2020 +0000

    Don't advertise ext-info-[cs] during rekeys.
    
    Apart from being pointless, it also triggers a bug in OpenSSH pre-8.1
    that causes it to send a repeat EXT_INFO after the rekey concludes,
    which trips our quite draconian check for whether EXT_INFO has been
    sent at the right time.
    
    The OpenSSH bug: https://bugzilla.mindrot.org/show_bug.cgi?id=2929

 ssh2transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)