simon-git: putty (master): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Sun Sep 13 09:16:00 BST 2020
TL;DR:
132d48b8 Remove redundant #includes from sshutils.c.
3daa3629 Remove dependency of sshrand.c on SHA-512.
a0580542 Introduce noproxy.c.
7003b439 Stop using mp_int in sshprng.c.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: master
Committer: Simon Tatham <anakin at pobox.com>
Date: 2020-09-13 09:16:00
commit 132d48b8f3d3bd619acb8a88dada46b54f4671f0
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=132d48b8f3d3bd619acb8a88dada46b54f4671f0;hp=56132d69c666192976a67b3227e4a6e77663c586
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Sep 13 08:29:35 2020 +0100
Remove redundant #includes from sshutils.c.
None of these was necessary at all. I think I must have just pasted
the existing list of includes when I split this file off from
sshcommon.c.
sshutils.c | 3 ---
1 file changed, 3 deletions(-)
commit 3daa36293ee2709e90578ae2277bf4f5532c63e8
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=3daa36293ee2709e90578ae2277bf4f5532c63e8;hp=132d48b8f3d3bd619acb8a88dada46b54f4671f0
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Sep 13 08:32:19 2020 +0100
Remove dependency of sshrand.c on SHA-512.
Rather like some of the tricks I did in mpint.h, this replaces the
unparametrised function random_setup_special() with one called
random_setup_custom() taking a hash-algorithm parameter.
The old syntax random_setup_special() still exists, and is a macro
wrapper on random_setup_custom() that passes ssh_sha512 as an
argument. This means I can keep the choice of hash function consistent
between the key generation front ends.
This adds potential flexibility: now, anyone wanting a different kind
of special RNG can make it out of whatever primitive they like. But a
more immediate point is to remove an inter-module dependency:
sshrand.c now doesn't need to be linked against the SHA-512 code.
putty.h | 11 ++++++++---
sshrand.c | 6 +++---
2 files changed, 11 insertions(+), 6 deletions(-)
commit a05805425355615c105bfb322fa94358d3ae2cc3
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=a05805425355615c105bfb322fa94358d3ae2cc3;hp=3daa36293ee2709e90578ae2277bf4f5532c63e8
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Sep 13 08:39:17 2020 +0100
Introduce noproxy.c.
For use in spinoff programs: this is an alternative to proxy.c, which
provides the same API (to avoid link failures in modules like
x11fwd.c) but implements it in the trivial way, supporting no proxying
at all and just wrapping the underlying sk_new() and friends.
noproxy.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
commit 7003b43963aef6cdf2841c2a882a684025f1d806
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=7003b43963aef6cdf2841c2a882a684025f1d806;hp=a05805425355615c105bfb322fa94358d3ae2cc3
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Sep 13 08:42:54 2020 +0100
Stop using mp_int in sshprng.c.
We keep an internal 128-bit counter that's used as part of the hash
preimages. There's no real need to import all the mp_int machinery in
order to implement that: we can do it by hand using a small fixed-size
array and a trivial use of BignumADC. This is another inter-module
dependency that's easy to remove and useful to spinoff programs.
This changes the hash preimage calculation in the PRNG, because we're
now formatting our 128-bit integer in the fixed-length representation
of 16 little-endian bytes instead of as an SSH-2 mpint. This is
harmless (perhaps even mildly beneficial, due to the length now not
depending on how long the PRNG has been running), but means I have to
update the PRNG tests as well.
sshprng.c | 16 +++++++++-------
test/cryptsuite.py | 12 +++++++++---
2 files changed, 18 insertions(+), 10 deletions(-)
More information about the tartarus-commits
mailing list