simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Apr 4 10:37:57 BST 2021


TL;DR:
  44c084f3 Windows Pageant: add --keylist option.
  0f61291f pageant.rc: make a header file of dialog/control ids.
  9e3d78bd winpgnt: add context help for 'Add Key (encrypted)' button.
  f5df09ad winpgnt: add GUI button to re-encrypt an SSH-2 key.
  39a72c16 winpgnt: fix accidental bisection of menu id definitions.
  b8374f1b winpgnt: menu options to delete/reencrypt everything.
  8edeecdc winpgnt: grey out key-list window buttons as appropriate.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-04-04 10:37:57

commit 44c084f33ffc72835f1b7f43b4903758d15fc2af
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=44c084f33ffc72835f1b7f43b4903758d15fc2af;hp=c1334f3b083a81e49639bb48125e8817e5ba0721
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 09:05:36 2021 +0100

    Windows Pageant: add --keylist option.
    
    This causes the main key list window to open when Pageant starts up,
    instead of waiting until you select 'View Keys' from the systray menu.
    
    My main motivation for adding this option is for development: if I'm
    _working_ on some detail of the key list window, it cuts down
    keystrokes in my edit-compile-retry cycle if I can have it
    automatically pop up in every new test run of Pageant.
    
    Normally I'd solve that by hacking an extra couple of lines
    temporarily into the code while I was doing that piece of development.
    But it suddenly struck me that there's no reason _not_ to add an
    option like this permanently (the space of word-length command-line
    flags is huge, and that particular one is unlikely to be needed for a
    different meaning), and who knows, it _might_ come in useful to
    someone in normal use. And at the very least it'll save me doing
    another temporary hack the next time I'm doing development work on the
    Pageant GUI. So I'll leave it in.

 windows/winpgnt.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

commit 0f61291f801d0b3b891c6a4e4394c5c6030f17f3
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=0f61291f801d0b3b891c6a4e4394c5c6030f17f3;hp=44c084f33ffc72835f1b7f43b4903758d15fc2af
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 09:27:47 2021 +0100

    pageant.rc: make a header file of dialog/control ids.
    
    I'm tired of remembering all those fiddly magic numbers and copying
    them back and forth between the .rc file and the source code. I'm even
    more tired of having to remember that in the long string of numbers
    after a dialog item definition, the first one of them _isn't_ one of
    the position and size coordinates. I've given them all symbolic names,
    like they should have had all along.
    
    I think I originally didn't bother because this was such a small GUI
    compared to the much larger one in PuTTY proper. But it's growing!

 windows/pageant-rc.h | 31 ++++++++++++++++++++
 windows/pageant.rc   | 56 ++++++++++++++++++++---------------
 windows/winpgnt.c    | 82 ++++++++++++++++++++++++++++------------------------
 3 files changed, 107 insertions(+), 62 deletions(-)

commit 9e3d78bddbc36ab82e6ac2e0ba1a7c69a90a747d
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=9e3d78bddbc36ab82e6ac2e0ba1a7c69a90a747d;hp=0f61291f801d0b3b891c6a4e4394c5c6030f17f3
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 09:34:50 2021 +0100

    winpgnt: add context help for 'Add Key (encrypted)' button.
    
    I wrote a docs section, but forgot to link it to the context help.

 doc/pageant.but   | 2 +-
 windows/winhelp.h | 1 +
 windows/winpgnt.c | 2 ++
 3 files changed, 4 insertions(+), 1 deletion(-)

commit f5df09adb7b2d5176aed873a3eaeafe1538d5fcb
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=f5df09adb7b2d5176aed873a3eaeafe1538d5fcb;hp=9e3d78bddbc36ab82e6ac2e0ba1a7c69a90a747d
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 09:42:00 2021 +0100

    winpgnt: add GUI button to re-encrypt an SSH-2 key.

 doc/pageant.but      | 21 +++++++++++----------
 pageant.c            |  8 ++++++++
 pageant.h            |  4 +++-
 windows/pageant-rc.h |  1 +
 windows/pageant.rc   | 13 +++++++------
 windows/winpgnt.c    | 20 ++++++++++++++++++--
 6 files changed, 48 insertions(+), 19 deletions(-)

commit 39a72c16cd7bf91fe0d37f33b10ee244cbf863af
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=39a72c16cd7bf91fe0d37f33b10ee244cbf863af;hp=f5df09adb7b2d5176aed873a3eaeafe1538d5fcb
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 09:51:35 2021 +0100

    winpgnt: fix accidental bisection of menu id definitions.
    
    Not quite sure how that happened! But at some point in the past, a bunch
    of other definitions in winpgnt.c managed to get in between the first
    few IDM_FOO constants and the last few. Bring them all back together.

 windows/winpgnt.c | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

commit b8374f1bdfacc4c83ab6ba5fb3c0faabe3330542
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=b8374f1bdfacc4c83ab6ba5fb3c0faabe3330542;hp=39a72c16cd7bf91fe0d37f33b10ee244cbf863af
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 10:02:24 2021 +0100

    winpgnt: menu options to delete/reencrypt everything.
    
    Now the systray menu includes 'Remove All Keys' and 'Re-encrypt All
    Keys' options, which do exactly what they say on the tin.

 pageant.c         | 13 +++++++++++++
 pageant.h         |  2 ++
 windows/winpgnt.c | 21 ++++++++++++++++++---
 3 files changed, 33 insertions(+), 3 deletions(-)

commit 8edeecdcfdfaca2fec63ee81f6f28856e695c1ef
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=8edeecdcfdfaca2fec63ee81f6f28856e695c1ef;hp=b8374f1bdfacc4c83ab6ba5fb3c0faabe3330542
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 4 10:14:05 2021 +0100

    winpgnt: grey out key-list window buttons as appropriate.
    
    Now the Remove button is disabled if there aren't any keys at all
    loaded, and the Re-encrypt button is disabled if no key is currently
    in a state where it's decrypted but re-encryptable.

 windows/winpgnt.c | 30 ++++++++++++++++++++++++++----
 1 file changed, 26 insertions(+), 4 deletions(-)



More information about the tartarus-commits mailing list