simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  3346b4b8 Fix one remaining MSVC warning for 32-bit targets.
  397d7564 test_split_into_argv: fix the generation mode.
  d028fd17 test_split_into_argv: add a -tabulate mode.
  49b91bc1 test_split_into_argv: update to post-VS7 behaviour.
  d01f682f test_split_into_argv: report test results sensibly.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-04-18 12:23:00

commit 3346b4b83fcd04e30c2a21eb6e456c889c64adce
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=3346b4b83fcd04e30c2a21eb6e456c889c64adce;hp=c314f582541cfacec0790eebd3bdf6e130ffc29f
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 18 11:08:27 2021 +0100

    Fix one remaining MSVC warning for 32-bit targets.
    
    One bit shift inside mp_divmod_into gave me "warning C4334: '<<':
    result of 32-bit shift implicitly converted to 64 bits". In this case
    it was actually on purpose: I intentionally did a shift that I
    expected to always fit in a BignumInt, and then I passed the result to
    mp_add_integer_into_shifted_by_words() which is general enough that it
    wants to accept the biggest integer type it can think of.
    
    It's easy to squelch the warning by using a temporary variable of the
    right type. Now I get a warning-clean build on VS2017, for both 64-
    and 32-bit.

 mpint.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit 397d75648d663cacfe21f0c070959b2dd2862259
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=397d75648d663cacfe21f0c070959b2dd2862259;hp=3346b4b83fcd04e30c2a21eb6e456c889c64adce
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 18 12:08:50 2021 +0100

    test_split_into_argv: fix the generation mode.
    
    Something weird was happening in the string handling which caused the
    output to be full of the kind of gibberish you expect to see from
    unterminated strings. Rather than debug it in detail, I've taken
    advantage of now having the utils library conveniently available, and
    simply used a strbuf, which I _know_ works sensibly.

 windows/utils/split_into_argv.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

commit d028fd17791d78aec40c444d60b50700dff6c1c3
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d028fd17791d78aec40c444d60b50700dff6c1c3;hp=397d75648d663cacfe21f0c070959b2dd2862259
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 18 12:10:04 2021 +0100

    test_split_into_argv: add a -tabulate mode.
    
    I've finally got round to updating this system for the fixed
    (post-VS7) command-line splitting. That means I need to regenerate the
    table in the big comment. So here's an automated method of doing it
    that doesn't require me to read off the output of -generate in an
    error-prone manual way.

 windows/utils/split_into_argv.c | 77 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)

commit 49b91bc128ab80349159c2595d29479b5d8aee82
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=49b91bc128ab80349159c2595d29479b5d8aee82;hp=d028fd17791d78aec40c444d60b50700dff6c1c3
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 18 12:10:53 2021 +0100

    test_split_into_argv: update to post-VS7 behaviour.
    
    The old behaviour is still present under an ifdef based on _MSC_VER,
    so it should still appear in the w32old builds we're still making.

 windows/utils/split_into_argv.c | 343 ++++++++++++++++++++++++++++------------
 1 file changed, 240 insertions(+), 103 deletions(-)

commit d01f682f32fb753df0652bb950fecaa47ee1b618
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=d01f682f32fb753df0652bb950fecaa47ee1b618;hp=49b91bc128ab80349159c2595d29479b5d8aee82
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Apr 18 12:13:39 2021 +0100

    test_split_into_argv: report test results sensibly.
    
    Now we say how many tests failed, and we also propagate the overall
    status into the exit code.

 windows/utils/split_into_argv.c | 27 ++++++++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)