simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Fri Dec 24 10:16:29 GMT 2021


TL;DR:
  831accb2 Expose openssh_bcrypt() to testcrypt, and test it.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-12-24 10:16:29

commit 831accb2a90b305422742ed2bb3eab5d927cee0e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=831accb2a90b305422742ed2bb3eab5d927cee0e;hp=c1ddacf78f75c463035a03371d2477d30ffa92ba
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Dec 24 09:56:30 2021 +0000

    Expose openssh_bcrypt() to testcrypt, and test it.
    
    I happened to notice in passing that this function doesn't have any
    tests (although it will have been at least somewhat tested by the
    cmdgen interop test system).
    
    This involved writing a wrapper that passes the passphrase and salt as
    ptrlens, and I decided it made more sense to make the same change to
    the original function too and adjust the call sites appropriately.
    
    I derived a test case by getting OpenSSH itself to make an encrypted
    key file, and then using the inputs and output from the password hash
    operation that decrypted it again.

 crypto/bcrypt.c       |  9 ++++-----
 import.c              | 11 +++++------
 ssh.h                 |  3 +--
 test/cryptsuite.py    | 14 ++++++++++++++
 test/testcrypt-func.h |  3 +++
 test/testcrypt.c      |  9 +++++++++
 6 files changed, 36 insertions(+), 13 deletions(-)



More information about the tartarus-commits mailing list