simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sat May 8 18:17:15 BST 2021


TL;DR:
  571fa338 Make TermWin's palette_get_overrides() take a Terminal *.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-05-08 18:17:15

commit 571fa3388d61f3270d958503c62f09669665f6f8
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=571fa3388d61f3270d958503c62f09669665f6f8;hp=a55aac71e4fa6cf30f976da6727877c4cb117c96
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat May 8 18:13:06 2021 +0100

    Make TermWin's palette_get_overrides() take a Terminal *.
    
    Less than 12 hours after 0.75 went out of the door, a user pointed out
    that enabling the 'Use system colours' config option causes an
    immediate NULL-dereference crash. The reason is because a chain of
    calls from term_init() ends up calling back to the Windows
    implementation of the palette_get_overrides() method, which responds
    by trying to call functions on the static variable 'term' in window.c,
    which won't be initialised until term_init() has returned.
    
    Simple fix: palette_get_overrides() is now given a pointer to the
    Terminal that it should be updating, because it can't find it out any
    other way.

 fuzzterm.c       |  2 +-
 putty.h          | 14 ++++++++++----
 terminal.c       |  2 +-
 unix/window.c    |  2 +-
 windows/window.c |  4 ++--
 5 files changed, 15 insertions(+), 9 deletions(-)



More information about the tartarus-commits mailing list