simon-git: xtruss (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Fri Sep 10 10:36:05 BST 2021


TL;DR:
  541afb7 Fix handling of EADDRINUSE.
  004eee5 Abort if we fail to make the X proxy.

Repository:     https://git.tartarus.org/simon/xtruss.git
On the web:     https://git.tartarus.org/?p=simon/xtruss.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2021-09-10 10:36:05

commit 541afb7bf9a3d29c3eb263945fba2f51e6cbcc2f
web diff https://git.tartarus.org/?p=simon/xtruss.git;a=commitdiff;h=541afb7bf9a3d29c3eb263945fba2f51e6cbcc2f;hp=2addd50b19b6635ebacd5df07fc92336ea360668
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Sep 10 10:28:36 2021 +0100

    Fix handling of EADDRINUSE.
    
    In the loop searching for a free TCP port to run an X display on, we
    should have continued to the next possible value if we _did_ get
    EADDRINUSE, and broken the loop if we failed to bind to a port for any
    other reason. But I got the sense of a strcmp the wrong way round, so
    we did the opposite. Oops.

 unix/ux_x11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 004eee589669468ee9455d6aaf0a87da6b9bdcb9
web diff https://git.tartarus.org/?p=simon/xtruss.git;a=commitdiff;h=004eee589669468ee9455d6aaf0a87da6b9bdcb9;hp=541afb7bf9a3d29c3eb263945fba2f51e6cbcc2f
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Sep 10 10:33:47 2021 +0100

    Abort if we fail to make the X proxy.
    
    The error with EADDRINUSE, which caused platform_make_x11_server() to
    return failure when it should have tried a different port number, made
    me realise that there's also no good handling for the case where it
    _does_ return failure.

 xtruss-proxy.c | 4 ++++
 1 file changed, 4 insertions(+)



More information about the tartarus-commits mailing list