simon-git: putty (main): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Sun Dec 4 11:58:02 GMT 2022
TL;DR:
95b92686 GTK: fix crash changing font size when terminal maximised.
Repository: https://git.tartarus.org/simon/putty.git
On the web: https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer: Simon Tatham <anakin at pobox.com>
Date: 2022-12-04 11:58:02
commit 95b926865a065e02b294b40ab899c8e921d87227
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=95b926865a065e02b294b40ab899c8e921d87227;hp=c14f0e02cce022c7bee77935238a4b34f3c3a261
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Dec 4 11:50:08 2022 +0000
GTK: fix crash changing font size when terminal maximised.
When I maximised a terminal window today and then used Ctrl-< to
reduce its font size (expecting that the window size would stay the
same but more characters would be squeezed in), pterm failed the
assertion in term_request_resize_completed() that checks
term->win_resize_pending == WIN_RESIZE_AWAIT_REPLY.
This happened because in this situation request_resize_internal() was
called from within window.c rather than from within the terminal code
itself. So the terminal didn't know a resize is pending at all, and
was surprised to be told that one had finished.
request_resize_internal() already has a flag parameter to tell it
whether a given resize came from the terminal or not. On the main code
path, that flag is used to decide whether to notify the terminal. But
on the early exit path when the window is maximised, we weren't
checking the flag. An easy fix.
unix/window.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
More information about the tartarus-commits
mailing list