simon-git: puzzles (main): Ben Harris

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Mon Dec 5 23:32:46 GMT 2022


TL;DR:
  8d81c18 lightup: Remove tests for keystrokes canonicalised by mid-end
  493d2fb Devel docs: make it clear that decode_ui() gets a new game_ui
  e5b0bca mosaic: Don't bother initialising fields in decode_ui()
  ea223a2 js: Put the puzzle background colour in a CSS variable
  9afdd4c guess: Fix keyboard access to hold function

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer:      Ben Harris <bjh21 at bjh21.me.uk>
Date:           2022-12-05 23:32:46

commit 8d81c1814d249d3aa2342c02363a0220c54bf71c
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=8d81c1814d249d3aa2342c02363a0220c54bf71c;hp=f8ed76f815494de031c86441bf392f8658ff383d
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon Dec 5 11:53:00 2022 +0000

    lightup: Remove tests for keystrokes canonicalised by mid-end
    
    Specifically, the mid-end will never pass ' ', '\r', or '\n' to the
    back-end, so it's pointless for the back-end to look for them.

 lightup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

commit 493d2fb138ba64faf795e1b4c01fd4f0d49075fc
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=493d2fb138ba64faf795e1b4c01fd4f0d49075fc;hp=8d81c1814d249d3aa2342c02363a0220c54bf71c
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon Dec 5 12:49:51 2022 +0000

    Devel docs: make it clear that decode_ui() gets a new game_ui
    
    At least one puzzle does no actual decoding in decode_ui, but does
    re-initialise some fields.  This is unnecessary because the mid-end only
    calls decode_ui() with a game_ui it just allocated using new_ui().

 devel.but | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit e5b0bcae5615d8829c8b5af2e3127397e7b72d8c
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=e5b0bcae5615d8829c8b5af2e3127397e7b72d8c;hp=493d2fb138ba64faf795e1b4c01fd4f0d49075fc
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon Dec 5 13:45:35 2022 +0000

    mosaic: Don't bother initialising fields in decode_ui()
    
    The game_ui is guaranteed to have been freshly generated by new_ui(),
    so there's no need to set fields to values that new_ui() has already
    set.

 mosaic.c | 5 -----
 1 file changed, 5 deletions(-)

commit ea223a23503c80759d5579626285eda0e617d6b4
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=ea223a23503c80759d5579626285eda0e617d6b4;hp=e5b0bcae5615d8829c8b5af2e3127397e7b72d8c
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon Dec 5 19:34:09 2022 +0000

    js: Put the puzzle background colour in a CSS variable
    
    It's sometimes useful to be able to have an HTML element that visually
    forms an extension of the puzzle's border.  By putting the puzzle's
    colour 0 (which we assume to be its background) into a CSS variable,
    such elements can do something like "background-color:
    var(--puzzle-background)" to get that effect even if the puzzle uses a
    non-default background colour.

 emcc.c     |  3 +++
 emcclib.js | 11 +++++++++++
 2 files changed, 14 insertions(+)

commit 9afdd4cca4823fa3b27ad2ca2fec33e04d7ab103
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=9afdd4cca4823fa3b27ad2ca2fec33e04d7ab103;hp=ea223a23503c80759d5579626285eda0e617d6b4
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date:   Mon Dec 5 23:16:04 2022 +0000

    guess: Fix keyboard access to hold function
    
    This has been broken since 2015.  It was accidentally using
    "IS_CURSOR_SELECT(button)" in place of "button == CURSOR_SELECT" and
    these are not the same thing.

 guess.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the tartarus-commits mailing list