simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Thu Feb 10 18:59:15 GMT 2022


TL;DR:
  aa015304 Fix handling of shifted SCO function keys.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-02-10 18:59:15

commit aa01530488e0b693172b513836fa6881d387ea8a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=aa01530488e0b693172b513836fa6881d387ea8a;hp=6f8db22972398b3a5439cbece0c7a7b678bdd7e4
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Feb 10 18:51:19 2022 +0000

    Fix handling of shifted SCO function keys.
    
    A user points out that this has regressed since 0.76, probably when I
    reorganised the keyboard control-sequence formatting into centralised
    helper functions in terminal.c.
    
    The SCO function keys should behave differently when you press Shift
    or Ctrl or both. For example, F1 should generate ESC[M bare, ESC[Y
    with Shift, Esc[k with Ctrl, Esc[w with Shift+Ctrl. But in fact, Shift
    was having no effect, so those tests would give ESC[M twice and ESC[k
    twice.
    
    That was because I was setting 'shift = false' for all function key
    types except FUNKY_XTERM_216, after modifying the derived 'index'
    value. But the SCO branch of the code doesn't use 'index' (it wouldn't
    have the right value in any case), so the sole effect was to forget
    about Shift. Easily fixed by disabling that branch for FUNKY_SCO too.

 terminal/terminal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the tartarus-commits mailing list