simon-git: putty (pre-0.77): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Fri Feb 11 20:06:25 GMT 2022


TL;DR:
  445f9de1 Fix handling of shifted SCO function keys.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: pre-0.77
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-02-11 20:06:25

commit 445f9de1297e408b9ca08f231873e312eb2222d4
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=445f9de1297e408b9ca08f231873e312eb2222d4;hp=9427f9699d1072f4598753e77681b3a8b59a48a7
Author: Simon Tatham <anakin at pobox.com>
Date:   Thu Feb 10 18:51:19 2022 +0000

    Fix handling of shifted SCO function keys.
    
    A user points out that this has regressed since 0.76, probably when I
    reorganised the keyboard control-sequence formatting into centralised
    helper functions in terminal.c.
    
    The SCO function keys should behave differently when you press Shift
    or Ctrl or both. For example, F1 should generate ESC[M bare, ESC[Y
    with Shift, Esc[k with Ctrl, Esc[w with Shift+Ctrl. But in fact, Shift
    was having no effect, so those tests would give ESC[M twice and ESC[k
    twice.
    
    That was because I was setting 'shift = false' for all function key
    types except FUNKY_XTERM_216, after modifying the derived 'index'
    value. But the SCO branch of the code doesn't use 'index' (it wouldn't
    have the right value in any case), so the sole effect was to forget
    about Shift. Easily fixed by disabling that branch for FUNKY_SCO too.
    
    (cherry picked from commit aa01530488e0b693172b513836fa6881d387ea8a)

 terminal/terminal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



More information about the tartarus-commits mailing list