simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  10f47902 windows/controls.c API: add lots of missing 'const'.
  68985ecb windows/controls.c: fix some nonstandard indentation.
  71f43af5 test/ca.py: fix handling of RFC4716 public key files.
  6737a190 cmdgen: human-readable certificate info dump.
  2bd2560a windows/puttygen.c: move control id enum further up the file.
  b66c56f4 Windows PuTTYgen: also display certificate info.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-07-30 17:21:53

commit 10f47902e5ccadf3929e65c3c67c54716483c6d6
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=10f47902e5ccadf3929e65c3c67c54716483c6d6;hp=138df73e81ddc732d71d66d8a7af2db2f0d826c4
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Jul 30 14:12:32 2022 +0100

    windows/controls.c API: add lots of missing 'const'.
    
    Most of the Windows-specific dialog control construction functions
    were passing their string parameters as 'char *' even though they were
    string literals. Apparently none of our previous giant constification
    patches spotted that.

 windows/controls.c | 82 ++++++++++++++++++++++++++++--------------------------
 windows/platform.h | 79 +++++++++++++++++++++++++++-------------------------
 2 files changed, 83 insertions(+), 78 deletions(-)

commit 68985ecb1e5f2579d3922064c78058545add300b
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=68985ecb1e5f2579d3922064c78058545add300b;hp=10f47902e5ccadf3929e65c3c67c54716483c6d6
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Jul 30 14:44:09 2022 +0100

    windows/controls.c: fix some nonstandard indentation.
    
    Happened to spot this while I was fixing the const issues in the
    previous commit.

 windows/controls.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

commit 71f43af5470b731470d2376661eabb5e40629ea8
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=71f43af5470b731470d2376661eabb5e40629ea8;hp=68985ecb1e5f2579d3922064c78058545add300b
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Jul 30 14:49:11 2022 +0100

    test/ca.py: fix handling of RFC4716 public key files.
    
    I must have dashed off that branch of the key reading function without
    ever testing it, or I'd have noticed by now that it was looking for
    the wrong string to terminate the file. Ahem.

 test/ca.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 6737a19072f39942a67708fe7353a38af35a787a
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=6737a19072f39942a67708fe7353a38af35a787a;hp=71f43af5470b731470d2376661eabb5e40629ea8
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Jul 30 16:10:45 2022 +0100

    cmdgen: human-readable certificate info dump.
    
    The recently added SeatDialogText type was just what I needed to add a
    method to the ssh_key vtable for dumping certificate information in a
    human-readable format. It will be good for displaying in a Windows
    dialog box as well as in cmdgen's text format.
    
    This commit introduces and implements the new method, and adds a
    --cert-info mode to command-line Unix PuTTYgen that uses it. The
    Windows side will follow shortly.

 cmdgen.c               |  85 ++++++++++++++++++++-
 crypto/openssh-certs.c | 202 +++++++++++++++++++++++++++++++++++++++++++++++++
 ssh.h                  |   3 +
 3 files changed, 289 insertions(+), 1 deletion(-)

commit 2bd2560a60f5f6c4a03bb645bfcf283f8cf47c83
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=2bd2560a60f5f6c4a03bb645bfcf283f8cf47c83;hp=6737a19072f39942a67708fe7353a38af35a787a
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Jul 30 14:23:43 2022 +0100

    windows/puttygen.c: move control id enum further up the file.
    
    I'm about to want setupbigedit1 and setupbigedit2 to know the control
    ids themselves, and also add more controls to the enum, and it keeps
    the diffs more legible if I move the entire enum around unchanged
    _first_ and then start making small changes in the middle of it.

 windows/puttygen.c | 72 +++++++++++++++++++++++++++---------------------------
 1 file changed, 36 insertions(+), 36 deletions(-)

commit b66c56f44129817540086c1c64e4d3e6631c31f4
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=b66c56f44129817540086c1c64e4d3e6631c31f4;hp=2bd2560a60f5f6c4a03bb645bfcf283f8cf47c83
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Jul 30 14:41:08 2022 +0100

    Windows PuTTYgen: also display certificate info.
    
    When PuTTYgen is holding a certified key, I don't think there's any
    sensible use for pasting around the full public key in authorized_keys
    format, because the whole point is that what you put in
    authorized_keys is 'please trust this CA' rather than the specific
    key. So instead I've reused the space in the dialog box to indicate
    that it's a certificate, and provide a 'more info' sub-dialog.

 windows/platform.h  |   1 +
 windows/puttygen.c  | 229 ++++++++++++++++++++++++++++++++++++++++++++++------
 windows/puttygen.rc |  10 +++
 3 files changed, 214 insertions(+), 26 deletions(-)