simon-git: putty (pre-0.77): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  bdab0034 Cancel drag-select when the context menu pops up.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: pre-0.77
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-03-29 18:15:55

commit bdab00341b9e2a48aeb329a40c9a1b8d521ab4a1
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=bdab00341b9e2a48aeb329a40c9a1b8d521ab4a1;hp=5d58931b51ff1223f1b2208956538cfadd702c0b
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Mar 29 18:05:11 2022 +0100

    Cancel drag-select when the context menu pops up.
    
    I got a pterm into a stuck state this morning by an accidental mouse
    action. I'd intended to press Ctrl + right-click to pop up the context
    menu, but I accidentally pressed down the left button first, starting
    a selection drag, and then while the left button was still held down,
    pressed down the right button as well, triggering the menu.
    
    The effect was that the context menu appeared while term->selstate was
    set to DRAGGING, in which state terminal output is suppressed, and
    which is only unset by a mouse-button release event. But then that
    release event went to the popup menu, and the terminal window never
    got it. So the terminal stayed stuck forever - or rather, until I
    guessed the cause and did another selection drag to reset it.
    
    This happened to me on GTK, but once I knew how I'd done it, I found I
    could reproduce the same misbehaviour on Windows by the same method.
    Added a simplistic fix, on both platforms, that cancels a selection
    drag if the popup menu is summoned part way through it.

 putty.h             |  1 +
 terminal/terminal.c | 17 +++++++++++++++++
 unix/window.c       |  2 ++
 windows/window.c    |  3 +++
 4 files changed, 23 insertions(+)