simon-git: putty (pre-0.77): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Wed May 4 20:13:32 BST 2022


TL;DR:
  af3520d2 Windows Pageant: fix off-by-one in -c option.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: pre-0.77
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-05-04 20:13:32

commit af3520d245c4c027eacb8e4efa2542f7f1e3a411
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=af3520d245c4c027eacb8e4efa2542f7f1e3a411;hp=03e71efcc513c9f13eb25b693b011b43f1f4a2d3
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed May 4 19:57:47 2022 +0100

    Windows Pageant: fix off-by-one in -c option.
    
    Apparently I never re-tested that option when I revamped Pageant's
    command-line option parsing in commit dc183e1649b429a, because it's
    now off by one in figuring out which argument to treat as the start of
    the command to be run.
    
    (The new code in that commit is the same shape as the old code but
    with variables renamed, and that was the mistake, because in the old
    code, the argument index i pointed to the -c option, whereas in the
    new code, match_opt has already advanced amo.index to the next word.
    So the two index variables _shouldn't_ be treated the same.)

 windows/pageant.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list