simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  fbb979aa Fix AES build on real Visual Studio.
  1d75ad4c Auth plugin: fix early socket closure.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-09-02 18:26:40

commit fbb979aa985cdcdbc6838a996da1420ba691b70f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=fbb979aa985cdcdbc6838a996da1420ba691b70f;hp=c8b66101ee57f1932498861a418be033a181d1dd
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Sep 2 18:14:21 2022 +0100

    Fix AES build on real Visual Studio.
    
    Apparently a nasty trick I did in one of the selector vtable macros
    was not acceptable to VS, which thinks that "string" ? NULL : NULL is
    not a constant expression - it can't tell that the string literal has
    a non-null value _or_ that it doesn't matter whether the value is null
    or not.
    
    Redone the vtable name construction in a way that depends only on the
    actual preprocessor, not on the followup C expression semantics.

 crypto/aes-select.c | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)

commit 1d75ad4c9359d4d6754101b30d09a0a5980e6f65
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=1d75ad4c9359d4d6754101b30d09a0a5980e6f65;hp=fbb979aa985cdcdbc6838a996da1420ba691b70f
Author: Simon Tatham <anakin at pobox.com>
Date:   Fri Sep 2 18:18:29 2022 +0100

    Auth plugin: fix early socket closure.
    
    My correspondent on the new authentication-plugin feature reports that
    their plugin is not reliably receiving the final PLUGIN_AUTH_SUCCESS
    message on Windows. I _think_ this is because the whole userauth layer
    is being dismissed, leading to sk_close() of the Socket talking to the
    plugin, before the data has actually been written to the outgoing
    pipe.
    
    This should fix it: track the Socket's backlog, and immediately after
    sending that message, wait until we receive a notification that the
    backlog has decreased to size 0. That stops us from terminating the
    userauth layer until the message has left our process.

 ssh/userauth2-client.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)