simon-git: putty (pre-0.78): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Tue Sep 13 15:02:00 BST 2022


TL;DR:
  b8473f0c Windows: remove static variables in wintw_request_resize.
  30372441 wintw_request_resize: add missing NACKs.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: pre-0.78
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2022-09-13 15:02:00

commit b8473f0c11e3356cdf84d38ee5edf2062fc32824
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=b8473f0c11e3356cdf84d38ee5edf2062fc32824;hp=49aa6c2b0899e322ca8acebd2a51b6a3f43028df
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Sep 13 11:11:59 2022 +0100

    Windows: remove static variables in wintw_request_resize.
    
    Those have been there since around 2001. They're in a piece of code
    that calls get_fullscreen_rect to find the overall screen size, and
    then prevents attempts to resize the window larger than that. The
    static variables were arranging that we don't have to call
    get_fullscreen_rect more than once.
    
    But, firstly, computers are faster 20 years on; secondly, remote
    window-resize requests are intentionally rate-limited (as of commit
    d74308e90e3813a), so this shouldn't be the limiting factor anyway; and
    thirdly, multi-monitor support has appeared since then, which means
    that if the window has been dragged from one monitor to another then
    get_fullscreen_rect might _legitimately_ return a different bounding
    rectangle when called a second time.
    
    So we should just do the full check every time unconditionally.
    
    (cherry picked from commit 4b3a8cbf61ce4ee19227784ba27c52a9e47774fb)

 windows/window.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

commit 3037244132fc1799a31ef42cbd02a9c3c8a2077c
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=3037244132fc1799a31ef42cbd02a9c3c8a2077c;hp=b8473f0c11e3356cdf84d38ee5edf2062fc32824
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue Sep 13 12:30:42 2022 +0100

    wintw_request_resize: add missing NACKs.
    
    In cases where we refuse a resize request, either because it's too
    large or because the window is not currently resizable due to being
    maximised, we were failing to communicate that back to the Terminal so
    that it could stop waiting for the resize and resume processing input.

 windows/window.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list