simon-git: putty (pre-0.79): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Wed Jun 7 07:37:08 BST 2023


TL;DR:
  6370782d PSFTP: make the 'close' subcommand return success.
  05a66999 PSFTP: fix memory leak opening two consecutive sessions.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: pre-0.79
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2023-06-07 07:37:08

commit 6370782de7acd48cbfd916e963720915dc0cc92f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=6370782de7acd48cbfd916e963720915dc0cc92f;hp=56b16bdc76591bf883eb66424a43a228977616c9
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Jun 7 07:12:58 2023 +0100

    PSFTP: make the 'close' subcommand return success.
    
    A user points out that it always returned failure, even if it
    succeeded. As a result, a 'psftp -b' script of the form
    
      open this.host
      do stuff
      close
      open that.host
      do stuff
      close
    
    would terminate at the first 'close', believing it to have failed, and
    PSFTP would exit with a failure status.
    
    (Not only that, but there would be no error message indicating _why_
    PSFTP had closed, because when a command returns failure it's expected
    to have printed an error message already.)

 psftp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 05a6699939e83aeeb6b850e055401b6a98880d6e
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=05a6699939e83aeeb6b850e055401b6a98880d6e;hp=6370782de7acd48cbfd916e963720915dc0cc92f
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed Jun 7 07:14:29 2023 +0100

    PSFTP: fix memory leak opening two consecutive sessions.
    
    Testing the script described in the previous commit message, Leak
    Sanitiser pointed out that we didn't free the LogContext from the
    first connection, and overwrote the pointer variable with the one from
    the second.

 psftp.c | 4 ++++
 1 file changed, 4 insertions(+)



More information about the tartarus-commits mailing list