simon-git: puzzles (main): Ben Harris
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Mon Jun 26 09:17:44 BST 2023
TL;DR:
0d005b5 Pearl: slightly better handling of clicks outside the grid
a56781b Distinguish MOVE_UNUSED from MOVE_NO_EFFECT in Galaxies
8b8a277 Fix control-character generation fix
Repository: https://git.tartarus.org/simon/puzzles.git
On the web: https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer: Ben Harris <bjh21 at bjh21.me.uk>
Date: 2023-06-26 09:17:44
commit 0d005b526ed554a165a83557512e745c8de335d6
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=0d005b526ed554a165a83557512e745c8de335d6;hp=c5076be383d7630d70666a543306c8f6ee65edb9
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date: Thu Jun 22 23:34:48 2023 +0100
Pearl: slightly better handling of clicks outside the grid
In Pearl, a mouse-down outside the grid sets ui->ndragcoords to -1.
The intended effect of this is to make sure that future drags are
ignored, so you can't try to draw a line starting off the grid.
However, this also has the effect of clearing any in-progress drag.
This can happen if there's a keyboard "drag" in progress at the time.
This is arguably wrong, but much more wrong was that interpret_move
returned MOVE_UNUSED (and previously NULL) in this case. That meant
that the display didn't get updated to show the abandonment of the
drag, or the removal of the keyboard cursor that also happened. This
commit changes MOVE_UNUSED to MOVE_UI_UPDATE so that at least the
effect is correctly visible.
pearl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit a56781bb695b11f8afdd012c703b4d6930d4aca8
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=a56781bb695b11f8afdd012c703b4d6930d4aca8;hp=0d005b526ed554a165a83557512e745c8de335d6
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date: Sun Jun 25 14:30:20 2023 +0100
Distinguish MOVE_UNUSED from MOVE_NO_EFFECT in Galaxies
The boundary between them for mouse clicks probably wants to be
revisited because at the moment it's slightly inside the edge of the
grid. I tried using INUI() instead of INGRID() but that just gives a
different wrong answer, so I may need to actually understand what's
going on here.
galaxies.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
commit 8b8a277a7aa9146b0825398f9e81ddccb81ee2dd
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=8b8a277a7aa9146b0825398f9e81ddccb81ee2dd;hp=a56781bb695b11f8afdd012c703b4d6930d4aca8
Author: Ben Harris <bjh21 at bjh21.me.uk>
Date: Mon Jun 26 09:10:28 2023 +0100
Fix control-character generation fix
The change I made in c224416c76e41f284b318adc51f08c3ed11de8e2 was
incorrect: I accidentally removed a "return" statement and left in a
debugging printf() when I meant to keep the return and drop the
printf().
midend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
More information about the tartarus-commits
mailing list