simon-git: puzzles (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sat Mar 4 14:40:36 GMT 2023


TL;DR:
  fe40cda Treat keypad-Enter as CURSOR_SELECT, same as Return.

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2023-03-04 14:40:36

commit fe40cda75a9665f7b464fa9909de0a7f62613817
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=fe40cda75a9665f7b464fa9909de0a7f62613817;hp=c0f715fbaca77fbb6e86de604098d82687bdea48
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Mar 4 14:30:37 2023 +0000

    Treat keypad-Enter as CURSOR_SELECT, same as Return.
    
    The two Return/Enter keys have always been treated the same in the
    past, but a user complained today that Enter was no longer functioning
    as CURSOR_SELECT in the web puzzles.
    
    This happened in commit 9dbcfa765ba59a8, apparently because the web
    front end is now translating the Enter key as MOD_NUM_KEYPAD | '\r'
    instead of just '\r', and the new code in midend.c is only stripping
    off MOD_NUM_KEYPAD for values >= 0x80.
    
    Now it strips MOD_NUM_KEYPAD off C0 control characters as well, so
    that only _printable_ ASCII characters can still have that modifier
    when they get to the backend - i.e. you can tell numpad digits from
    normal digits, and ditto +-* etc. But keypad Enter is now turned into
    plain '\r' by the modifier removal code, and then into CURSOR_SELECT.
    
    Other front ends still aren't even bothering to set MOD_NUM_KEYPAD on
    the code sent by Enter. But that's fine, because now midend.c
    officially doesn't care whether they do or not.

 midend.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)



More information about the tartarus-commits mailing list