simon-git: putty (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Sun Mar 5 13:33:13 GMT 2023


TL;DR:
  adb0fd12 term_init(): initialise term->ldisc.
  c8426a74 Build test_terminal for Windows too.
  74aa3cb7 term_init(): actually, memset the whole structure to 0.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2023-03-05 13:33:13

commit adb0fd12f5e7de14c62f5979bf68557ad151fbb9
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=adb0fd12f5e7de14c62f5979bf68557ad151fbb9;hp=a76109c586944d9ace03ca6a54b7f8173f6c0deb
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Mar 5 13:23:24 2023 +0000

    term_init(): initialise term->ldisc.
    
    In live uses of Terminal, we always give it an ldisc almost
    immediately after creating it. But the new test_terminal program
    doesn't, which allows it to be an uninitialised pointer. Apparently I
    got lucky while testing this the first few times.

 terminal/terminal.c | 1 +
 1 file changed, 1 insertion(+)

commit c8426a748e250756dfb0fb9128f1c08df673dabe
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=c8426a748e250756dfb0fb9128f1c08df673dabe;hp=adb0fd12f5e7de14c62f5979bf68557ad151fbb9
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Mar 5 13:24:07 2023 +0000

    Build test_terminal for Windows too.
    
    I'm not conveniently set up to actually run it during my main build,
    since that happens entirely on Linux and cross-builds the Windows
    binaries. But it should at least be possible to build and run it by
    hand.

 windows/CMakeLists.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

commit 74aa3cb7fb088d8b162f885a11de473b83dce3b2
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=74aa3cb7fb088d8b162f885a11de473b83dce3b2;hp=c8426a748e250756dfb0fb9128f1c08df673dabe
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Mar 5 13:26:09 2023 +0000

    term_init(): actually, memset the whole structure to 0.
    
    This avoids any further problems with non-NULL pointers, and also
    allows me to throw out a lot of boilerplate initialisation of
    pointers, integers and booleans to NULL, 0 or false respectively. (Of
    course, all the initialisations to _other_ values have to stay.)

 terminal/terminal.c | 64 +----------------------------------------------------
 1 file changed, 1 insertion(+), 63 deletions(-)



More information about the tartarus-commits mailing list