simon-git: gonville (main): Simon Tatham
Commits to Tartarus hosted VCS
tartarus-commits at lists.tartarus.org
Sun Oct 29 09:48:49 GMT 2023
TL;DR:
ac4cdd1 Make glyphs.py --ver actually work!
21a541e Give the SMuFL fonts a version number.
Repository: https://git.tartarus.org/simon/gonville.git
On the web: https://git.tartarus.org/?p=simon/gonville.git
Branch updated: main
Committer: Simon Tatham <anakin at pobox.com>
Date: 2023-10-29 09:48:49
commit ac4cdd118e7faa3db50cb94f47695ffb61a79896
web diff https://git.tartarus.org/?p=simon/gonville.git;a=commitdiff;h=ac4cdd118e7faa3db50cb94f47695ffb61a79896;hp=4ec6d4f3b2cc85f31e03811aa3d55457e1e43d94
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Oct 29 09:10:25 2023 +0000
Make glyphs.py --ver actually work!
Because the primary option spelling is --ver, it sets a field called
'ver' in the output object of argparse. But I was retrieving
args.verstring rather than args.ver, so that whatever you passed to
--ver was ignored.
That would normally have caused a Python exception to let me know of
the mistake, except that I also set a default value for the wrong
field 'verstring', so that it did have a value to retrieve. Memo to
self: using parser.set_defaults() risks this kind of spelling mismatch
in a way that adding default='foo' to the add_argument call does not.
As a result, none of my font files actually had a version number. Now
fixed, ahem.
glyphs.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
commit 21a541ebf03aee5752ca6c3a2fdec9b93d4ab353
web diff https://git.tartarus.org/?p=simon/gonville.git;a=commitdiff;h=21a541ebf03aee5752ca6c3a2fdec9b93d4ab353;hp=ac4cdd118e7faa3db50cb94f47695ffb61a79896
Author: Simon Tatham <anakin at pobox.com>
Date: Sun Oct 29 09:00:57 2023 +0000
Give the SMuFL fonts a version number.
Now that --ver actually works again, it makes a difference that I left
it out of the 'glyphs.py --smufl' invocation, whereas I put it in for
the Lilypond runs. Reinstated.
Also, I've put a version number in the zip file name too. Not doing
that in the previous commit was a mistake, but fortunately, I've only
given the URL to a few people for test purposes so far, and warned
them that it won't be permanent.
I've also stopped providing the individual SMuFL font files as
separate build products, because I'd have to rename them to have
version numbers in, and I don't think that's particularly useful.
Easier to have a zip file containing files with standard names (so
that when you unpack it, you don't have to adjust whatever was
pointing at the file), but version the zip file itself.
Buildscr | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
More information about the tartarus-commits
mailing list