simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  11c7c760 Remove bit-rotted RDB_DEBUG_PATCH.
  1fc5f4af wm_size_resize_term: update conf unconditionally.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2024-12-15 15:13:54

commit 11c7c7608c5199a914d11f9f5d830e83041946f8
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=11c7c7608c5199a914d11f9f5d830e83041946f8;hp=c91437bae3a9aef1e235a0dc00669dc91a76c6e3
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Dec 15 14:25:23 2024 +0000

    Remove bit-rotted RDB_DEBUG_PATCH.
    
    I was about to try to debug a window resizing issue, and it looked as
    if this patch had a plausible set of diagnostics already. But in fact
    when I turned on this #ifdef it failed to compile, so I'm getting rid
    of it.
    
    Perhaps there is a use for having types of diagnostic living
    permanently in the source code and easy to enable in themed sets, but
    if so, I think they'd be better compiled in and enabled by an option,
    than compiled out and enabled by #ifdef. That way they're less likely
    to rot, and also, you can ask a user to turn one on really easily and
    get extra logs for whatever is bothering them!

 windows/window.c | 54 ------------------------------------------------------
 1 file changed, 54 deletions(-)

commit 1fc5f4afd1b554b498f470749237d4fea7a9a405
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=1fc5f4afd1b554b498f470749237d4fea7a9a405;hp=11c7c7608c5199a914d11f9f5d830e83041946f8
Author: Simon Tatham <anakin at pobox.com>
Date:   Sun Dec 15 14:48:01 2024 +0000

    wm_size_resize_term: update conf unconditionally.
    
    A user reported that when a PuTTY window is resized by the
    'FancyZones' tool included in Microsoft PowerToys, the terminal itself
    knows the new size ('stty' showed that it had sent a correct SIGWINCH
    to the SSH server), but the next invocation of the Change Settings
    dialog box still has the old size entered in it, leading to confusing
    behaviour when you press Apply.
    
    Inside PuTTY, this must mean that we updated the actual terminal's
    size, but didn't update the main Conf object to match it, which is
    where Change Settings populates its initial dialog state from.
    
    It looks as if this is because FancyZones resizes the window by
    sending it one single WM_SIZE, without wrapping it in the
    WM_ENTERSIZEMOVE and WM_EXITSIZEMOVE messages that signal the start
    and end of an interactive dragging resize operation. And the update of
    Conf in wm_size_resize_term was in only one branch of the if statement
    that checks whether we're in an interactive resize. Now it's outside
    the if, so Conf will be updated in both cases.

 windows/window.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)