simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  27550b02 Windows: inhibit all default application manifests.

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2024-12-16 18:55:38

commit 27550b02e26c71a9638ff25aeaeff32183ca5a3f
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=27550b02e26c71a9638ff25aeaeff32183ca5a3f;hp=363debc7f09791a905b94dd6cae96328210ca742
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Dec 16 18:44:47 2024 +0000

    Windows: inhibit all default application manifests.
    
    In 0.81 and before, we put an application manifest (XML-formatted
    Windows resource) into all the GUI tools on purpose, and the CLI tools
    like Plink didn't have one. But in 0.82, the CLI tools do have one,
    and it's a small default one we didn't write ourselves, inserted by
    some combination of cmake and clang-imitating-MSVC (I haven't checked
    which of those is the cause).
    
    This appears to have happened as a side effect of a build-tools
    update, not on purpose. And its effect is that Windows XP now objects
    to our plink.exe, because it's very picky about manifest format (we
    have an old 'xp-wont-run' bug record about that).
    
    Since it seemed to work fine to not have a manifest at all in 0.81,
    let's go back to that. We were already passing /manifest:no to inhibit
    the default manifest in the GUI tools, to stop it fighting with our
    custom one; now I've moved /manifest:no into the global linker flags,
    so it's applied to _all_ binaries, whether we're putting our own
    manifest in or not.

 cmake/platforms/windows.cmake |  4 +---
 windows/CMakeLists.txt        | 20 +++++---------------
 2 files changed, 6 insertions(+), 18 deletions(-)