simon-git: mastodonochrome (main): Simon Tatham

Commits to Tartarus hosted VCS tartarus-commits at lists.tartarus.org
Mon Feb 5 19:21:56 GMT 2024


TL;DR:
  dcbcb9a Fix bug with restoring file position on [Q]/[RET].

Repository:     https://git.tartarus.org/simon/mastodonochrome.git
On the web:     https://git.tartarus.org/?p=simon/mastodonochrome.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2024-02-05 19:21:56

commit dcbcb9aee2ea95779df9151408455fc0b82c8dde
web diff https://git.tartarus.org/?p=simon/mastodonochrome.git;a=commitdiff;h=dcbcb9aee2ea95779df9151408455fc0b82c8dde;hp=37bab54f92041e4f0c5599714c9fb0f97b131e50
Author: Simon Tatham <anakin at pobox.com>
Date:   Mon Feb 5 19:13:16 2024 +0000

    Fix bug with restoring file position on [Q]/[RET].
    
    I noticed recently that if I did this ...
    
     - examine a user and press [P][O] (or [P][T]) to see their posts
     - file position appears at the top of the feed, with an extension indicator
     - press [0] to extend, then [0] again to go to the top
     - pick a post in view and look at its thread
     - press [Q] to pop the activity stack back to the rest of the user's posts
    
    ... then the file position in the user's posts feed was not restored
    to where it had been before I went to look at a thread. This turned
    out to be because of the call to state.show_new_content() in
    ensure_activity_state(), which was resetting the position to the
    latest _read_ thing, not the place we had had the focus before.
    
    That call was intended to update the position if you were 'moved' into
    an interrupting feed like your mentions, from the same feed, so that
    it would update to show the new thing. So it only really needs to
    trigger in the case where 'is_interrupt' is set. Now it does.

 src/tui.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)



More information about the tartarus-commits mailing list