simon-git: putty (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  400c895c settings.c: Don't ignore boolean settings

Repository:     https://git.tartarus.org/simon/putty.git
On the web:     https://git.tartarus.org/?p=simon/putty.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2024-07-13 14:29:46

commit 400c895cedc1e454aee3e44022cf15f2343b6740
web diff https://git.tartarus.org/?p=simon/putty.git;a=commitdiff;h=400c895cedc1e454aee3e44022cf15f2343b6740;hp=a5bcf3d384e1bf15a51a6923c3724cbbee022d8e
Author: Mark Wooding <mdw at distorted.org.uk>
Date:   Fri Jul 12 17:28:51 2024 +0100

    settings.c: Don't ignore boolean settings
    
    Revision 1b2f39c24bb6591a4192377d9393f5c3e45cb5bd introduced guards to
    use the built-in defaults in the event that the SESSKEY was null.  This
    was later reverted in 39c20d4819794417e4e84429d1eb5430e3865b25 because
    (a) a null SESSKEY is precisely how the absence of a per-session
    configuration file is signalled to the backend, and (b) everything could
    apparently already cope with a null SESSKEY anyway.
    
    Unfortunately, in between these, 3214563d8ed7469e20d4ffdddd55c430334ce803
    introduced new functions for handling boolean-valued settings.  The
    reversion didn't affect the new `gppb_raw' function, which retained the
    erroneous guard against null SESSKEY.  In consequence, PuTTY ignores
    X resources and `-xrm' settings unless `~/.putty/sessions/Default%20Settings'
    exists, causing undesirable behaviour such as starting login shells,
    establishing `utmp' entries, scrolling on output, failing to scroll on
    keypress, not blinking the cursor, etc.
    
    This isn't a total disaster: touching `~/.putty/sessions/Default%20Settings'
    makes the problem go away.  But it seems worth fixing anyway.
    
    Apply the obvious one-line fix.
    
    Signed-off-by: Mark Wooding <mdw at distorted.org.uk>

 settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)