simon-git: puzzles (main): Simon Tatham

[Commits to Tartarus hosted VCS]

TL;DR:
  28e519b Clarify documentation of request_keys() and button2label().
  abe1eed Untangle: fix redraws when dragging with cursor keys.
  1ece22b Guess: make cursor visible at low resolution.
  877133a Group: implement game_request_keys().
  5edcabb Group: implement game_get_cursor_location().

Repository:     https://git.tartarus.org/simon/puzzles.git
On the web:     https://git.tartarus.org/?p=simon/puzzles.git
Branch updated: main
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2025-02-07 08:45:20

commit 28e519b08fde9fe0f0b3c4d5d8a84e17a8337231
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=28e519b08fde9fe0f0b3c4d5d8a84e17a8337231;hp=79be403101d055d2fde3611a5f133135d4094ee9
Author: Franklin Wei <franklin at rockbox.org>
Date:   Fri Jan 3 00:43:22 2025 -0500

    Clarify documentation of request_keys() and button2label().
    
    I'm starting to question why the "label" field of the key_label struct
    is dynamically allocated in the first place. Only Undead sets it to
    anything other than NULL, and I see no reason that wouldn't work with
    statically allocated string constants.
    
    (Doing some archaeology shows that the dynamically allocated "label"
    field was introduced by... me! I can only wonder what I was thinking 7
    years ago when I first wrote that code. But that's a problem for
    another time...)

 devel.but | 85 ++++++++++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 54 insertions(+), 31 deletions(-)

commit abe1eed3baa9617a7b52c861d159f832ffbba4c6
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=abe1eed3baa9617a7b52c861d159f832ffbba4c6;hp=28e519b08fde9fe0f0b3c4d5d8a84e17a8337231
Author: Franklin Wei <franklin at rockbox.org>
Date:   Wed Jan 1 18:49:13 2025 -0500

    Untangle: fix redraws when dragging with cursor keys.
    
    The recent addition of graph editor functionality to Untangle in
    2ac951e broke redraws while dragging a point using the cursor keys. In
    particular, the new ui->dragtype field was not being set by the cursor
    dragging code path, causing redraws to erroneously exit early.
    
    Generally, there is quite a bit of code duplication between the cursor
    and mouse dragging code paths in interpret_move(). Some refactoring
    could perhaps reduce the chances of this happening again.

 untangle.c | 1 +
 1 file changed, 1 insertion(+)

commit 1ece22b75827a9c310bc9311dc04ac006489ff54
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=1ece22b75827a9c310bc9311dc04ac006489ff54;hp=abe1eed3baa9617a7b52c861d159f832ffbba4c6
Author: Franklin Wei <franklin at rockbox.org>
Date:   Fri Jan 3 21:03:02 2025 -0500

    Guess: make cursor visible at low resolution.
    
    On many Rockbox devices, the cursor in Guess is invisible due to the low
    screen resolution, which causes CGAP to round down to zero. This change
    imposes a lower bound of 1 pixel.
    
    Interestingly, this is less of an issue on front ends with antialiasing,
    since the cursor peg's black border is overdrawn twice with, causing its
    hazy antialiased boundary to get noticeably darker, even when CGAP is zero.

 guess.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 877133ae5d22f4bc99bfd43f6b1520a902755619
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=877133ae5d22f4bc99bfd43f6b1520a902755619;hp=1ece22b75827a9c310bc9311dc04ac006489ff54
Author: Franklin Wei <franklin at rockbox.org>
Date:   Fri Jan 3 00:37:21 2025 -0500

    Group: implement game_request_keys().
    
    This should allow keyboard-less play with Rockbox (and other front ends).

 unfinished/group.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

commit 5edcabb967adb1b032bd46e4abb9c0015cd8a3c7
web diff https://git.tartarus.org/?p=simon/puzzles.git;a=commitdiff;h=5edcabb967adb1b032bd46e4abb9c0015cd8a3c7;hp=877133ae5d22f4bc99bfd43f6b1520a902755619
Author: Franklin Wei <franklin at rockbox.org>
Date:   Fri Jan 3 21:58:31 2025 -0500

    Group: implement game_get_cursor_location().
    
    This should allow zoomed-in play on Rockbox.

 unfinished/group.c | 6 ++++++
 1 file changed, 6 insertions(+)