simon-git: putty (pre-0.64): Simon Tatham

[Commits to Tartarus CVS repository.]

TL;DR:
  2ef23bb Fix typo in validate_manual_hostkey().
  068b67d Clarify when ldisc->term may be NULL.
  b6c2346 Fix uninitialised variable in two Windows event loops.
  90dcef3 Fix assorted memory leaks.
  69d50b2 Don't reject _and_ accept X forwarding requests!
  f454235 Add some missing initialisations.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: pre-0.64
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2014-11-22 16:09:16

commit 2ef23bb8128503feefa36ca90a85c74e4dd62a9b
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=2ef23bb8128503feefa36ca90a85c74e4dd62a9b;hp=063c438fec892a5d03e0853baa6aa0cf963e7a50
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 10:12:47 2014 +0000

    Fix typo in validate_manual_hostkey().
    
    'p += strcspn' returns p always non-NULL and sometimes pointing at \0,
    as opposed to 'p = strchr' which returns p sometimes non-NULL and
    never pointing at \0. Test the pointer after the call accordingly.
    Thanks, Coverity.

 misc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

commit 068b67d2f6e9b186b3107ebcb1e88a141b7b5ebc
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=068b67d2f6e9b186b3107ebcb1e88a141b7b5ebc;hp=2ef23bb8128503feefa36ca90a85c74e4dd62a9b
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 10:37:14 2014 +0000

    Clarify when ldisc->term may be NULL.
    
    Namely, any ldisc that you send actual data through should have a
    terminal attached, because the ldisc editing/echoing system is
    designed entirely for use with a terminal. The only time you can have
    an ldisc with no terminal is when it's only ever used by the backend
    to report changes to the front end in edit/echo status, e.g. by Unix
    Plink.
    
    Coverity spotted an oddity in ldisc_send which after a while I decided
    would never have actually caused a problem, but OTOH I agree that it
    was confusing, so now hopefully it's less so.

 ldisc.c |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

commit b6c2346173ee1a8b8cd6ec045bb80243e47400f2
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=b6c2346173ee1a8b8cd6ec045bb80243e47400f2;hp=068b67d2f6e9b186b3107ebcb1e88a141b7b5ebc
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 10:18:16 2014 +0000

    Fix uninitialised variable in two Windows event loops.
    
    If (Msg)WaitForMultipleObjects returns WAIT_TIMEOUT, we expect 'next'
    to have been initialised. This can occur without having called
    run_timers(), if a toplevel callback was pending, so we can't expect
    run_timers to have reliably initialised 'next'.
    
    I'm not actually convinced this could have come up in either of the
    affected programs (Windows PSFTP and Plink), due to the list of things
    toplevel callbacks are currently used for, but it certainly wants
    fixing anyway for the future.
    
    Spotted by Coverity.

 windows/winplink.c |    3 +++
 windows/winsftp.c  |    3 +++
 2 files changed, 6 insertions(+)

commit 90dcef3d9e60f7f81193e433771bcb11e057cf11
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=90dcef3d9e60f7f81193e433771bcb11e057cf11;hp=b6c2346173ee1a8b8cd6ec045bb80243e47400f2
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 09:58:15 2014 +0000

    Fix assorted memory leaks.
    
    All spotted by Coverity.

 ssh.c              |    3 +++
 sshshare.c         |   16 ++++++++++++++--
 windows/winshare.c |    2 ++
 3 files changed, 19 insertions(+), 2 deletions(-)

commit 69d50b2877ea6cb2a23a75e563dbca7548dacd38
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=69d50b2877ea6cb2a23a75e563dbca7548dacd38;hp=90dcef3d9e60f7f81193e433771bcb11e057cf11
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 09:59:37 2014 +0000

    Don't reject _and_ accept X forwarding requests!
    
    If a sharing downstream asks for an auth method we don't understand,
    we should send them CHANNEL_FAILURE *and then stop processing*. Ahem.
    
    (Spotted while examining this code in the course of Coverity-related
    fixes, but not itself a Coverity-found problem.)

 sshshare.c |    2 ++
 1 file changed, 2 insertions(+)

commit f45423544437d117d103a3406550dcd535c614b9
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=f45423544437d117d103a3406550dcd535c614b9;hp=69d50b2877ea6cb2a23a75e563dbca7548dacd38
Author: Simon Tatham <anakin at pobox.com>
Date:   Sat Nov 22 14:57:06 2014 +0000

    Add some missing initialisations.
    
    Spotted by valgrind, after I was testing all the Coverity bug fixes :-)

 dialog.c |    2 ++
 ssh.c    |    2 ++
 2 files changed, 4 insertions(+)