simon-git: putty (master): Simon Tatham

Tue May 5 20:18:25 BST 2015

TL;DR:
  bcfcb16 Const-correctness in public-key functions.
  a53e4e2 Const-correctness in x11_setup_display.
  5ba2d61 Move half of Pageant out into a cross-platform source file.
  7b60785 Cross-platform support for speaking SSH agent protocol on a Socket.
  76e2ffe Move make_dir_and_check_ours() out into uxmisc.c.
  c521082 Provide a Unix port of Pageant.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-05-05 20:18:25

commit bcfcb169efab1587a7cebcffff9efbf9ccac8ce8
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=bcfcb169efab1587a7cebcffff9efbf9ccac8ce8;hp=6b303169225f9e3ce62dd90445be61865af9b104
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue May 5 20:16:17 2015 +0100

    Const-correctness in public-key functions.

    Several of the functions in ssh2_signkey, and one or two SSH-1 key
    functions too, were still taking assorted non-const buffer parameters
    that had never been properly constified. Sort them all out.

 import.c |    4 ++--
 ssh.c    |    5 +++--
 ssh.h    |   22 +++++++++++-----------
 sshdss.c |   42 ++++++++++++++++++++++--------------------
 sshecc.c |   45 +++++++++++++++++++++++----------------------
 sshrsa.c |   41 +++++++++++++++++++++--------------------
 6 files changed, 82 insertions(+), 77 deletions(-)

commit a53e4e2cb6aa5b953fa0cdbef3b1702d0925f195
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=a53e4e2cb6aa5b953fa0cdbef3b1702d0925f195;hp=bcfcb169efab1587a7cebcffff9efbf9ccac8ce8
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue May 5 20:16:18 2015 +0100

    Const-correctness in x11_setup_display.

    The 'display' parameter should have been a const char *. No call sites
    affected.

 ssh.h    |    2 +-
 x11fwd.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

commit 5ba2d611f9346701b7b5b983b605cb7641fb19d7
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=5ba2d611f9346701b7b5b983b605cb7641fb19d7;hp=a53e4e2cb6aa5b953fa0cdbef3b1702d0925f195
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue May 5 20:16:19 2015 +0100

    Move half of Pageant out into a cross-platform source file.

    I'm aiming for windows/winpgnt.c to only contain the parts of Windows
    Pageant that are actually to do with handling the Windows API, and for
    all the actual agent logic to be cross-platform.

    This commit is a start: I've moved every function and internal
    variable that was easy to move. But it doesn't get all the way there -
    there's still a lot of logic in add_keyfile() and get_keylist*() that
    would be good to move out to cross-platform code, but it's harder
    because that code is currently quite intertwined with details of
    Windows OS interfacing such as printing message boxes and passphrase
    prompts and calling back out to agent_query if the Pageant doing that
    job isn't the primary one.

 Recipe            |    6 +-
 pageant.c         |  767 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 pageant.h         |   67 +++++
 windows/winpgnt.c |  776 ++++-------------------------------------------------
 4 files changed, 890 insertions(+), 726 deletions(-)

commit 7b6078533e71571a77a216cb069f80f3781c377d
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=7b6078533e71571a77a216cb069f80f3781c377d;hp=5ba2d611f9346701b7b5b983b605cb7641fb19d7
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue May 5 20:16:20 2015 +0100

    Cross-platform support for speaking SSH agent protocol on a Socket.

    The exact nature of the Socket is left up to the front end to decide,
    so that we can use a Unix-domain socket on Unix and a Windows named
    pipe on Windows. But the logic of how we receive data and what we send
    in response is all cross-platform.

 pageant.c |  183 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 pageant.h |   13 +++++
 2 files changed, 196 insertions(+)

commit 76e2ffe49d55f2cb805f4a5650f589e22b3d0f17
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=76e2ffe49d55f2cb805f4a5650f589e22b3d0f17;hp=7b6078533e71571a77a216cb069f80f3781c377d
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue May 5 20:16:22 2015 +0100

    Move make_dir_and_check_ours() out into uxmisc.c.

    I'm going to want to use it for a second purpose in a minute.

 unix/unix.h    |    1 +
 unix/uxmisc.c  |   32 ++++++++++++++++++++++++++++++++
 unix/uxshare.c |   31 -------------------------------
 3 files changed, 33 insertions(+), 31 deletions(-)

commit c52108234b62b388efbd44447dc2e572fbd16240
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=c52108234b62b388efbd44447dc2e572fbd16240;hp=76e2ffe49d55f2cb805f4a5650f589e22b3d0f17
Author: Simon Tatham <anakin at pobox.com>
Date:   Tue May 5 20:16:23 2015 +0100

    Provide a Unix port of Pageant.

    This is much more like ssh-agent than the Windows version is - it sets
    SSH_AUTH_SOCK and SSH_AGENT_PID as its means of being found by other
    processes, rather than Windows Pageant's approach of establishing
    itself in a well-known location. But the actual agent code is the same
    as Windows Pageant.

    For the moment, this is an experimental utility and I don't expect it
    to be useful to many people; its immediate use to me is that it
    provides a way to test and debug the agent code on Unix, and also to
    use the agent interface as a convenient way to exercise public key
    functions I want to debug. And of course it means I can be constantly
    using and testing my own code, on whatever platform I happen to be
    using. In the further future, I have a list of possible features I
    might add to it, but I don't know which ones I'll decide are
    worthwhile.

    One feature I've already put in is a wider range of lifetime
    management options than ssh-agent: the -X mode causes Pageant to make
    a connection to your X display, and automatically terminate when that
    connection closes, so that it has the same lifetime as your X session
    without having to do the cumbersome trick of exec()ing the subsequent
    session-management process.

 Recipe        |    4 +
 unix/uxpgnt.c |  517 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 521 insertions(+)