simon-git: putty (master): Simon Tatham

Commits to Tartarus CVS repository. tartarus-commits at lists.tartarus.org
Wed May 6 19:47:24 BST 2015


TL;DR:
  340143c Remove some FIXMEs left in from initial work.
  bc4066e Put proper logging into Pageant.

Repository:     git://git.tartarus.org/simon/putty.git
On the web:     http://tartarus.org/~simon-git/gitweb/?p=putty.git
Branch updated: master
Committer:      Simon Tatham <anakin at pobox.com>
Date:           2015-05-06 19:47:24

commit 340143cea7d65d6a340e40126e17518154bbbe78
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=340143cea7d65d6a340e40126e17518154bbbe78;hp=c52108234b62b388efbd44447dc2e572fbd16240
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed May 6 18:08:05 2015 +0100

    Remove some FIXMEs left in from initial work.
    
    LIFE_EXEC is already dealt with, and I forgot to take out the comment
    reminding me to do it, ahem.
    
    The LIFE_PARENT mentioned in the same comment was an idea I had but
    couldn't think of a way to make it work: if you have a terminal-only
    shell session in which you want to eval $(ssh-agent), then it's
    annoying and fragile to have to remember to kill the agent when you
    log out, so you'd like it to automatically tie its lifetime to that of
    the shell from which you invoked it. Unfortunately, I don't know of
    any way to do that without race conditions. (E.g. if only pageant
    didn't fork, then it could poll its own ppid until it became 1 - but
    the child process would find it was 1 already.)

 unix/uxpgnt.c |    9 ---------
 1 file changed, 9 deletions(-)

commit bc4066e454f38358f17860e3d4244f63b930f994
web diff http://tartarus.org/~simon-git/gitweb/?p=putty.git;a=commitdiff;h=bc4066e454f38358f17860e3d4244f63b930f994;hp=340143cea7d65d6a340e40126e17518154bbbe78
Author: Simon Tatham <anakin at pobox.com>
Date:   Wed May 6 19:32:26 2015 +0100

    Put proper logging into Pageant.
    
    Now it actually logs all its requests and responses, the fingerprints
    of keys mentioned in all messages, and so on.
    
    I've also added the -v option, which causes Pageant in any mode to
    direct that logging information to standard error. In --debug mode,
    however, the logging output goes to standard output instead (because
    when debugging, that information changes from a side effect to the
    thing you actually wanted in the first place :-).
    
    An internal tweak: the logging functions now take a va_list rather
    than an actual variadic argument list, so that I can pass it through
    several functions.

 pageant.c         |  309 +++++++++++++++++++++++++++++++++++++++++++++--------
 pageant.h         |   11 +-
 unix/uxpgnt.c     |   37 ++++---
 windows/winpgnt.c |    2 +-
 4 files changed, 294 insertions(+), 65 deletions(-)



More information about the tartarus-commits mailing list